Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helix precommand is expanding semicolon to new lines. #2070

Closed
LoopedBard3 opened this issue Oct 13, 2021 · 1 comment · Fixed by #2074
Closed

Helix precommand is expanding semicolon to new lines. #2070

LoopedBard3 opened this issue Oct 13, 2021 · 1 comment · Fixed by #2074
Assignees
@LoopedBard3
Labels
bug Something isn't working
Milestone
.NET7 MQ

Comments

@LoopedBard3
Copy link
Member

Helix precommand is expanding semicolons in strings to new lines. This caused issue #2056. A temporary solution to that issue was made in PR #2069, but this needs to be investigated further and hopefully changed back.
@LoopedBard3 LoopedBard3 self-assigned this Oct 13, 2021
@LoopedBard3 LoopedBard3 added the bug Something isn't working label Oct 13, 2021
@LoopedBard3 LoopedBard3 added this to the .NET7 MQ milestone Oct 13, 2021
@LoopedBard3 LoopedBard3 mentioned this issue Oct 13, 2021
Merged
@LoopedBard3
Copy link
Member Author

According to https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/Sdk/Readme.md, it looks like semicolons are escaped with semicolons. So to get an actual semi-colon in the strings we need to use ;;. A PR for this in this and the runtime repo will be up soon.

This was referenced Oct 14, 2021
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LoopedBard3 LoopedBard3

Labels
bug Something isn't working
Projects
None yet
Milestone
.NET7 MQ
1 participant
@LoopedBard3