Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Improvement on 8/5/2022 3:19:16 AM #7263

Closed
performanceautofiler bot opened this issue Aug 11, 2022 · 0 comments
Closed

[Perf] Improvement on 8/5/2022 3:19:16 AM #7263

performanceautofiler bot opened this issue Aug 11, 2022 · 0 comments

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS ubuntu 18.04
Baseline 8daeec27929d15576f034a8743c2c9c524d24609
Compare dafc6dfd9dd0a38adc3ff10b0f178b3920151ce7
Diff Diff

Improvements in System.Text.Json.Serialization.Tests.ReadJson<ArrayList>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
DeserializeFromStream - Duration of single invocation 82.82 μs 57.22 μs 0.69 0.25 False
DeserializeFromUtf8Bytes - Duration of single invocation 78.03 μs 58.95 μs 0.76 0.27 False
DeserializeFromString - Duration of single invocation 84.08 μs 56.71 μs 0.67 0.22 False

graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ReadJson&lt;ArrayList&gt;*'

Payloads

Baseline
Compare

Histogram

System.Text.Json.Serialization.Tests.ReadJson<ArrayList>.DeserializeFromStream


Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 57.223585924902096 < 78.19251039210525.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 8/4/2022 3:21:43 PM, 8/5/2022 7:33:33 PM falls between 7/28/2022 6:13:35 AM and 8/5/2022 7:33:33 PM.
IsImprovementStdDev: Marked as improvement because 11.359601667670214 (T) = (0 -59299.75567700029) / Math.Sqrt((11592779.410540907 / (299)) + (8620961.679054985 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.2854594376722914 = (82990.0481560118 - 59299.75567700029) / 82990.0481560118 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ReadJson&lt;ArrayList&gt;.DeserializeFromUtf8Bytes

```log

Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 58.94620396449705 < 75.14854208253016.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 8/4/2022 3:21:43 PM, 8/5/2022 7:33:33 PM falls between 7/28/2022 6:13:35 AM and 8/5/2022 7:33:33 PM.
IsImprovementStdDev: Marked as improvement because 8.352021842228805 (T) = (0 -56169.19380140891) / Math.Sqrt((10696864.129123073 / (299)) + (15423570.891789636 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.2927271086950483 = (79416.57950126451 - 56169.19380140891) / 79416.57950126451 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ReadJson&lt;ArrayList&gt;.DeserializeFromString

```log

Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 56.70605888030888 < 75.98774409297974.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 8/4/2022 3:21:43 PM, 8/5/2022 7:33:33 PM falls between 7/28/2022 6:13:35 AM and 8/5/2022 7:33:33 PM.
IsImprovementStdDev: Marked as improvement because 40.107061282076955 (T) = (0 -57250.484208116206) / Math.Sqrt((10566373.062592085 / (299)) + (592797.875116222 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.28749353515986353 = (80350.82772331248 - 57250.484208116206) / 80350.82772331248 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture arm64
OS ubuntu 18.04
Baseline 8daeec27929d15576f034a8743c2c9c524d24609
Compare dafc6dfd9dd0a38adc3ff10b0f178b3920151ce7
Diff Diff

Improvements in System.Text.Json.Serialization.Tests.ReadJson<Hashtable>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
DeserializeFromStream - Duration of single invocation 122.97 μs 101.60 μs 0.83 0.18 False
DeserializeFromString - Duration of single invocation 124.97 μs 99.32 μs 0.79 0.22 False
DeserializeFromUtf8Bytes - Duration of single invocation 130.69 μs 100.30 μs 0.77 0.16 False

graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ReadJson&lt;Hashtable&gt;*'

Payloads

Baseline
Compare

Histogram

System.Text.Json.Serialization.Tests.ReadJson<Hashtable>.DeserializeFromStream


Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 101.59511342592594 < 116.16631360172764.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 8/4/2022 3:21:43 PM, 8/5/2022 7:33:33 PM falls between 7/28/2022 6:13:35 AM and 8/5/2022 7:33:33 PM.
IsImprovementStdDev: Marked as improvement because 7.358159947671021 (T) = (0 -97690.08833908738) / Math.Sqrt((21949212.67698446 / (299)) + (30498441.85767705 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.22770339263227599 = (126492.96579464692 - 97690.08833908738) / 126492.96579464692 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ReadJson&lt;Hashtable&gt;.DeserializeFromString

```log

Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 99.31887763921473 < 115.86930272270246.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 8/4/2022 3:21:43 PM, 8/5/2022 7:33:33 PM falls between 7/28/2022 6:13:35 AM and 8/5/2022 7:33:33 PM.
IsImprovementStdDev: Marked as improvement because 11.797160891258807 (T) = (0 -97104.69125940459) / Math.Sqrt((26734213.220121518 / (299)) + (9805242.649073534 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.2134910608434497 = (123462.92130327133 - 97104.69125940459) / 123462.92130327133 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Serialization.Tests.ReadJson&lt;Hashtable&gt;.DeserializeFromUtf8Bytes

```log

Description of detection logic

IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed:Marked as improvement because 100.29599294743844 < 117.14615502856464.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 8/4/2022 3:21:43 PM, 8/5/2022 7:33:33 PM falls between 7/28/2022 6:13:35 AM and 8/5/2022 7:33:33 PM.
IsImprovementStdDev: Marked as improvement because 53.9057096040839 (T) = (0 -99961.7236008166) / Math.Sqrt((19657848.31860545 / (299)) + (223471.99218199425 / (2))) is greater than 1.9679296690655894 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (2) - 2, .975) and 0.18512613397482813 = (122671.40691161732 - 99961.7236008166) / 122671.40691161732 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants