Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: 6 Improvements on 8/17/2024 8:06:13 AM #40003

Closed
performanceautofiler bot opened this issue Aug 17, 2024 · 5 comments
Closed

[Perf] Windows/x64: 6 Improvements on 8/17/2024 8:06:13 AM #40003

performanceautofiler bot opened this issue Aug 17, 2024 · 5 comments

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Mac OS X 10.18
Queue IPhone
Baseline 0fbd81404d1f211572387498474063bc6f407f0f
Compare 1a305e63ecf47e81464ca22b6ddc86d2d31c6202
Diff Diff
Configs CompilationMode:tiered, HybridGlobalization:true, iOSStripSymbols:false, RunKind:ios_scenarios, RuntimeType:nativeaot

Improvements in SOD - iOS HelloWorld NativeAOT .app Size nollvm symbols

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
4.30 MB 3.43 MB 0.80 0.00 True
4.30 MB 3.43 MB 0.80 0.00 True
4.30 MB 3.43 MB 0.80 0.00 True
4.30 MB 3.43 MB 0.80 0.00 True
980.00 bytes 981.00 bytes 1.00 0.00 True
980.00 bytes 981.00 bytes 1.00 0.00 True

graph
graph
graph
graph
graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'SOD - iOS HelloWorld NativeAOT .app Size nollvm symbols*'

SOD - iOS HelloWorld NativeAOT .app Size nollvm symbols

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@matouskozak
Copy link
Member

There are two improvements hidden under this issue:
image

The bigger one comes from dotnet/runtime@0396978...5daadaa, could it possible be dotnet/runtime#105877 @filipnavara ?

The smaller one comes from dotnet/runtime@ca99ff4...b1908e2 and could be related to dotnet/runtime#106444, also @filipnavara.

The improvements are HUGE on NativeAOT-ios, we went from 4.5MB to 3.17 MB, fyi @MichalStrehovsky @ivanpovazan

@matouskozak
Copy link
Member

The smaller one comes from dotnet/[email protected] and could be related to dotnet/runtime#106444, also @filipnavara.

That PR doesn’t affect Windows at all.

This is NativeAOT on iOS measurements (The Windows/x64 in the issue name is just the host machine)

@filipnavara
Copy link
Member

filipnavara commented Aug 20, 2024

I suspect there may be some improvement from c5302af59371d1b6278abc826445221d570eed34 by upgrading the Apple tooling. dotnet/runtime#106444 is unlikely to make any difference, but f856f4f04d8bdd4d162227064ad09fbb306a5f91 may, depending on how the apps are linked...

@matouskozak
Copy link
Member

matouskozak commented Aug 20, 2024

I suspect there may be some improvement from c5302af59371d1b6278abc826445221d570eed34 by upgrading the Apple tooling. dotnet/runtime#106444 is unlikely to make any difference, but f856f4f04d8bdd4d162227064ad09fbb306a5f91 may, depending on how the apps are linked...

The dotnet/runtime@c5302af looks to be only for official builds. dotnet/runtime#106446 makes sense. Thanks and good job, these improvements are big!

@matouskozak
Copy link
Member

@ivanpovazan found out that the improvements only affected Mono NativeAOT-iOS sample app scenario due to the way the app is build. We are likely not going to see these improvements on MAUI application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants