Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResolveAssemblyReference spends 2.3% of its time in LogReference, even on silent verbosities #2700

Closed
cdmihai opened this issue Nov 3, 2017 · 2 comments
Closed

ResolveAssemblyReference spends 2.3% of its time in LogReference, even on silent verbosities #2700

cdmihai opened this issue Nov 3, 2017 · 2 comments
Assignees
@rokonec
Labels
performance Performance-Scenario-Build This issue affects build performance. Performance-Scenario-Solution-Open This issue affects solution open performance. triaged

Comments

@cdmihai
Copy link
Contributor

cdmihai commented Nov 3, 2017 •
edited
Loading

Measured this while building Roslyn with /clp:PerformanceSummary;Summary /v:m

image

It would be nice if RAR had access to the highest verbosity requested by any logger, and skip this on low verbosities.
@cdmihai
Copy link
Contributor Author

cdmihai commented Nov 3, 2017 •
edited
Loading

There's a flag to turn off LogReference, probably used for design time builds: https://github.com/Microsoft/msbuild/blob/75e5117ab8be40faad4601904600aceae6bf9ee1/src/Tasks/Microsoft.Common.CurrentVersion.targets#L2026-L2027

However, #2417 suggests that there may be a bug somewhere and BuildingProject gets to be true during CPS based design time builds

@AndyGerlicher AndyGerlicher added this to the MSBuild 15.6 milestone Nov 6, 2017
@panopticoncentral panopticoncentral added Performance-Scenario-Solution-Open This issue affects solution open performance. Performance-Scenario-Build This issue affects build performance. labels Jun 9, 2020
@panopticoncentral panopticoncentral removed this from the MSBuild 15.6 milestone Jun 9, 2020
@ladipro ladipro assigned ladipro and rokonec and unassigned ladipro Nov 30, 2020
@rokonec rokonec mentioned this issue Dec 1, 2020
Merged
@rokonec
Copy link
Contributor

rokonec commented Dec 1, 2020

PR #5924

@rokonec rokonec closed this as completed Dec 15, 2020
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rokonec rokonec

Labels
performance Performance-Scenario-Build This issue affects build performance. Performance-Scenario-Solution-Open This issue affects solution open performance. triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@panopticoncentral @cdmihai @AndyGerlicher @ladipro @rokonec @AR-May