Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate layout requests up the tree for Content/Layout Views #7297

Merged
merged 1 commit into from
May 18, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented May 18, 2022

Description of Change

Makes the backing views for layouts/content on iOS propagate layout requests to their parents, if available. So layout changes which require resizing/remeasuring actually work.

Also removes unnecessary SetNeedsLayout call when switching visibility.

Issues Fixed

Fixes #6420
Fixes #7217

Remove unnecessary SetNeedsLayout call when switching visibility
Fixes #6420; Fixes #7217
@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label May 18, 2022
@rmarinho rmarinho merged commit 4b833b0 into main May 18, 2022
@rmarinho rmarinho deleted the fix-6420 branch May 18, 2022 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.400 Look for this fix in 6.0.400! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-6.0.400 Look for this fix in 6.0.400!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] - Frame not resizing. Grid doesn't dynamically size when content size changes
4 participants