-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Show keyboard when Entry, Editor and SearchBar get focus #5995
Conversation
} | ||
else | ||
{ | ||
platformView?.HideKeyboard(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens here if you are tabbing through multiple fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have something like:
StackLayout
- Entry
- Entry
- Entry
If we have the focus on the first entry, and pass the focus to the second one:
- The first Entry loses focus and the keyboard closes.
- The second Entry gains focus so the keyboard is reopened.
That is, the keyboard would close and open in a short time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel like that's the behavior we'd want here. If we want to maintain some level of behavior here with MAUI then I would say at the controls level if the user calls "FOCUS" then we open the keyboard but then that's it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keyboard visibility was very broken in XF. I don't think we should just bring this code straight over. Someone also logged this same bug on XF against iOS xamarin/Xamarin.Forms#8952
To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR is not included in the next release so I close it for now. I will reopen it and adapt to changes later. |
Description of Change
Show/hide keyboard when Entry, Editor and SearchBar get or lost focus.
Issues Fixed
Fixes #5983