Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Remove IgnoreIfPlatforms usage on UITests #22525

Closed
jsuarezruiz opened this issue May 20, 2024 · 0 comments · Fixed by #22526
Closed

[Testing] Remove IgnoreIfPlatforms usage on UITests #22525

jsuarezruiz opened this issue May 20, 2024 · 0 comments · Fixed by #22526
Assignees
@jsuarezruiz
Labels
area-testing Unit tests, device tests fixed-in-8.0.60 fixed-in-9.0.0-preview.6.24327.7 platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 s/triaged Issue has been reviewed t/bug Something isn't working
Milestone
.NET 8 SR6

Comments

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented May 20, 2024 •
edited
Loading

Description

Remove IgnoreIfPlatforms usage on UITests.

IgnoreIfPlatforms is a extension method used until now in some UITests to ignore the test on some platforms. However, the sample app was launched, navigated to the issue page and then ignored. This takes some valious time. In this PR, we are removing the extension method and including some Ignore attributes to ignore the test directly.

Steps to Reproduce

No response

Link to public reproduction project repository

No response

Version with bug

8.0.40 SR5

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android, Windows, macOS

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response
@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-testing Unit tests, device tests labels May 20, 2024
@dotnet-policy-service dotnet-policy-service bot added the s/triaged Issue has been reviewed label May 20, 2024
@jsuarezruiz jsuarezruiz self-assigned this May 20, 2024
@jsuarezruiz jsuarezruiz added this to the Backlog milestone May 20, 2024
@jsuarezruiz jsuarezruiz moved this from Todo to In Progress in MAUI SDK Ongoing May 20, 2024
@jsuarezruiz jsuarezruiz mentioned this issue May 20, 2024
Merged
@jsuarezruiz jsuarezruiz modified the milestones: Backlog, .NET 8 SR6 May 21, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR6, .NET 8 SR7 Jun 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Jun 7, 2024
@samhouts samhouts modified the milestones: .NET 8 SR7, .NET 8 SR6 Jul 1, 2024
@MartyIX MartyIX mentioned this issue Aug 15, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jsuarezruiz jsuarezruiz

Labels
area-testing Unit tests, device tests fixed-in-8.0.60 fixed-in-9.0.0-preview.6.24327.7 platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 s/triaged Issue has been reviewed t/bug Something isn't working
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR6
Development

Successfully merging a pull request may close this issue.

[Testing] Remove IgnoreIfPlatforms usage on UITests dotnet/maui
3 participants
@PureWeen @jsuarezruiz @samhouts