-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[regression/8.0.0] Entry pushed under keyboard and off the page iOS #16784
Comments
@SamuelJames101 thank you for the feedback. I am trying to reproduce your issue, but I am having a little trouble following along with the steps. I see that you included a repo, but I do not see the code to produce your issue. Would you be able to push your code to that repo? It may also help us validate with some images or video of the behavior you are seeing. |
@tj-devel709 Sorry, I have updated that now |
We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process. |
@SamuelJames101 were you able to get this working in 7.0.49? For us the Keyboard usage in Scrollviews is also buggy in iOS in that version. |
Can't comment on ScrollViews but this exact issue wasn't happening in net 7 as I was handling the entry being covered by the keyboard on iOS myself. Although there were plenty of other buggy behaviours around ScrollViews, ListViews and CollectionViews |
Verified this on Visual Studio Enterprise 17.8.0 Preview 1.0 using below Project (.NET 8.0) in iOS 16.4. |
@AnnYang01 I will produce a video showing it getting pushed off the screen |
@AnnYang01 I have now edited the bug item and attached a video for iOS |
@SamuelJames101 thank you for your update, we verified this issue in an iOS simulator and it did not repro, from your video, it can repro in a device. |
@SamuelJames101 I'm testing this on net7 and I'm not seeing the editor staying on top of the keyboard. We didn't have any code in net7 that tried to auto scroll when the keyboard opened. We just added this in net8. It looks like we need to adjust the scroll a little but I don't see this working in net7. Everything just stays in place |
@PureWeen Sorry, yeah you’re correct. It was working in the sense that I handled the keyboard being overlapped myself. That no longer works however with these new changes in .net8 |
@SamuelJames101 if you turn off the new scroll features in net8 does that fix?
|
We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process. |
Hi @SamuelJames101. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time. |
@SamuelJames101 hi we have the overlap issue in net 7 are you willing to share your experience we solution to the issue? Many thanks |
@PureWeen What am I targeting to use that disconnect feature? |
@developer9969 Hello, You can create a custom handler for a custom contentView. Using that new custom content view on the pages in which you don't want the keyboard overlap. For iOS you can then hook into the "UIKeyboard.Notifications.ObserveWillShow(OnKeyboardShow)" events on the handler. When the "OnKeyboardShow" method is ran you can then set the pages bottom padding to the height of the keyboard. I used " NSValue result = (NSValue)e.Notification.UserInfo.ObjectForKey(new NSString(UIKeyboard.FrameEndUserInfoKey)); |
Hi, @SamuelJames101. You can try calling something like this: using Microsoft.Maui.Platform;
...
#if IOS
KeyboardAutoManagerScroll.Disconnect();
#endif It is currently hard to find a place to call this (in lifecycle events) since it looks like a lot of the lifecycle events are called prior to the Connect counterpart being called. I have a fix I'm working on now for this. Sorry for the inconvenience! |
@AnnYang01, I am also seeing the editor not coming up high enough. There seems to be a corner case with some layouts that have a grid as the top level in the keyboard scrolling logic and I am looking at that now. |
This PR landed for GA and will make it easier to call the |
Here is the issue for this here: #18354 |
I'm going to close the issue here for now @SamuelJames101. If calling the Disconnect method and keeping your original custom code does not work, please feel free to reopen this issue. This issue sort of split into two different issues - @AnnYang01 please follow the progress and add any other comments for the grid issue here: #18354 |
Description
Editor / Entry should be attached to keyboard when opened and not get pushed under it, or pushed off the page. (Works on Android, Not tested WinUI and Mac).
Steps to Reproduce
Create a Grid set RowDefinitions to (*,Auto)
Create a CollectionView at the top of the page (grid:0).
Create an editor at the bottom of the page (grid:1).
Using the repo add an item to the CollectionView. (Type into the box and hit enter)
Repeat step 3
Expected Result:
The Editor remains at the top of the keyboard.
Actual Result:
The Editor is pushed under the keyboard.
Expected Result:
The Editor is back at the bottom of the screen and the collectionView takes up its given space.
Actual Result:
The Editor is pushed off the screen with the CollectionView taking up full height
Link to public reproduction project repository
https://github.com/SamuelJames101/KeyboardCollectionViewIssues
Version with bug
8.0.0-preview.7.8842
Is this a regression from previous behavior?
Yes, this used to work in .NET MAUI
Last version that worked well
7.0.49
Affected platforms
iOS (13.1.1, iPhone 11 Pro), I was not able test on other platforms, os versions or devices
Affected platform versions
No response
Did you find any workaround?
No response
Relevant log output
No response
RPReplay_Final1692865580.mp4
I can also push it off the page by simply clicking the 'Fill Collection' button
The text was updated successfully, but these errors were encountered: