Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollectionView inside RefreshView causes layout problems on iOS #11440

Closed
owl-guy opened this issue Nov 17, 2022 · 8 comments
Closed

CollectionView inside RefreshView causes layout problems on iOS #11440

owl-guy opened this issue Nov 17, 2022 · 8 comments
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/iOS 🍎 t/bug Something isn't working
Milestone

Comments

@owl-guy
Copy link

owl-guy commented Nov 17, 2022

Description

maui_ios_layout_bug

If you put a CollectionView inside a RefreshView and switch from portrait to landscape and back on iOS, the layout gets messed up.

Steps to Reproduce

""

Link to public reproduction project repository

#11363

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

iOS16 and up

Did you find any workaround?

No response

Relevant log output

No response

@owl-guy owl-guy added the t/bug Something isn't working label Nov 17, 2022
@owl-guy
Copy link
Author

owl-guy commented Nov 17, 2022

It gets even worse if you put a grid around it...

@jsuarezruiz jsuarezruiz added area-controls-collectionview CollectionView, CarouselView, IndicatorView area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter platform/iOS 🍎 labels Nov 17, 2022
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Nov 17, 2022
@ghost
Copy link

ghost commented Nov 17, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@Redth Redth added the partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with label Jan 12, 2023
@Redth
Copy link
Member

Redth commented Jan 12, 2023

This seems to be an issue with controls inside the CV, not the collectionview itself. I switched the usage of Frame to Border and the issue resolved.

@Redth Redth closed this as completed Jan 12, 2023
@owl-guy
Copy link
Author

owl-guy commented Jan 13, 2023

This seems to be an issue with controls inside the CV, not the collectionview itself. I switched the usage of Frame to Border and the issue resolved.

Wait what? That doesn't make it better! It's still a problem. You can't simply close this ticket because "Hey, it works with Border"

@RobTF
Copy link

RobTF commented Feb 1, 2023

@owl-guy you have it all wrong, it's just a documentation issue;

We clearly just need a matrix of which controls can appear on the screen with which other controls, and specifically how they are allowed to do so. Maybe it's a per-platform thing too (certainly the RefreshView stuff is).

;)

@ghost
Copy link

ghost commented Feb 1, 2023

Hello lovely human, thank you for your comment on this issue. Because this issue has been closed for a period of time, please strongly consider opening a new issue linking to this issue instead to ensure better visibility of your comment. Thank you!

@krookdfinger
Copy link

Wrap the collection view in contentview and it will work

`

<ContentPage.Resources>
    <DataTemplates:ProductDataTemplateSelector x:Key="ProductTemplates" />
</ContentPage.Resources>

<RefreshView Command="{Binding RefreshCommand}"
             IsRefreshing="{Binding IsRefreshing}">
    **<ContentView>**
        <CollectionView ItemsSource="{Binding Products}"
                        ItemTemplate="{StaticResource ProductTemplates}">

        **</CollectionView>**
    </ContentView>
</RefreshView>
`

@ghost
Copy link

ghost commented Feb 13, 2023

Hello lovely human, thank you for your comment on this issue. Because this issue has been closed for a period of time, please strongly consider opening a new issue linking to this issue instead to ensure better visibility of your comment. Thank you!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants