Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YML should upload produced packages as pipeline artifacts #164

Open
ViktorHofer opened this issue Nov 11, 2024 · 2 comments
Open

YML should upload produced packages as pipeline artifacts #164

ViktorHofer opened this issue Nov 11, 2024 · 2 comments
Assignees

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 11, 2024

We should have packages available in the pipeline run as pipeline artifacts for inspection. This makes it easier to double check PR changes.

@carlossanlop
Copy link
Member

I was thinking about this the other day. I noticed we do generate the packages, they just don't get stored in a persistent location.

Will we get any kind of pushback from dnceng for using a lot of new space? We would basically create a new persistent artifact location for every commit in a PR. Unless they get deleted and overriden whenever a new commit is pushed?

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Nov 13, 2024

Nope, we do this in every repository. Pipeline artifacts are expected to be used and they a retention policy setting attached anyway. It's perfectly fine to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants