-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests need their own environment implementation #925
Comments
Thank you @Ivanidzo4ka .. if I agree with everything you say. To refine and make a best test, we have also spoken about having an abstract environment class capable of outputting to a user's preferred logging framework, it might be nice indeed if this thing followed that example -- if it cannot that might itself be a test that the leve of abtraction imagined is insufficient. |
Can I take a shot at this? What would I have to do? (If it's still an open issue) |
Feel free to. In terms of what you need to do, you need to implement class based on IHostEnviroment interface inside TestFramework project, which would consume channel messages and propagate them to IOutputHelper.
|
Is this still relevant or is it resolved/handled by #4710 ? |
Right now we use TlcEnvironment (or ConsoleEnvironment) which outputs everything to console.
And XUnit don't care about console, and if you want to look on output during test execution you need to do something like this:
machinelearning/test/Microsoft.ML.StaticPipelineTesting/StaticPipeTests.cs
Line 31 in 4cb7dd9
We should have XUnitEnvironment or TestEnvironment and redirect all output to ITestOutputHelper.
The text was updated successfully, but these errors were encountered: