Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.ML.Tokenizers.Tests.TiktokenTests.TestTokenizerUsingExternalVocab failing to download gpt2.tiktoken #7256

Closed
1 of 3 tasks
ericstj opened this issue Oct 1, 2024 · 5 comments
Assignees
Labels
Known Build Error Use this to report build issues in the .NET Helix tab

Comments

@ericstj
Copy link
Member

ericstj commented Oct 1, 2024

Build

https://dev.azure.com/dnceng-public/public/_build/results?buildId=823668

Build leg reported

Microsoft.ML.Tokenizers.Tests.TiktokenTests.TestTokenizerUsingExternalVocab

Pull Request

#7252

Known issue core information

Fill out the known issue JSON section by following the step by step documentation on how to create a known issue

 {
    "ErrorMessage" : ["Microsoft.ML.Tokenizers.Tests.TiktokenTests.TestTokenizerUsingExternalVocab", "File not found"],
    "BuildRetry": false,
    "ErrorPattern": "",
    "ExcludeConsoleLog": false
 }

@dotnet/dnceng

Release Note Category

  • Feature changes/additions
  • Bug fixes
  • Internal Infrastructure Improvements

Release Note Description

Additional information about the issue reported

It looks to me like this file no longer exists:
https://github.com/dotnet/machinelearning/blob/be1e428d41b5936903172855f7f30861ca7eb49a/test/Microsoft.ML.Tokenizers.Tests/TitokenTests.cs#L100C136-L100C149

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=823668
Error message validated: [Microsoft.ML.Tokenizers.Tests.TiktokenTests.TestTokenizerUsingExternalVocab File not found]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/4/2024 12:37:23 AM UTC

Report

Build Definition Test Pull Request
823668 dotnet/machinelearning Microsoft.ML.Tokenizers.Tests.WorkItemExecution #7252

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 1 1
@ericstj ericstj added the Known Build Error Use this to report build issues in the .NET Helix tab label Oct 1, 2024
@dougbu
Copy link
Member

dougbu commented Oct 1, 2024

@ericstj may I ask why this is a dotnet/dnceng issue❓ shouldn't it be moved into dontet/machinelearning❓

@tarekgh
Copy link
Member

tarekgh commented Oct 1, 2024

I think it is fine to move it to the machinelearning repo. I don't have permission to do so though.

@dougbu
Copy link
Member

dougbu commented Oct 1, 2024

I don't have the required rights in machinelearning either. @mmitche can you transfer the issue❓

@ericstj
Copy link
Member Author

ericstj commented Oct 4, 2024

Oh that's odd. Maybe I clicked the wrong button when opening this. I'll transfer. Sorry for that.

@ericstj ericstj transferred this issue from dotnet/dnceng Oct 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged label Oct 4, 2024
@tarekgh
Copy link
Member

tarekgh commented Oct 4, 2024

Should be fixed now by the PR #7248.

@tarekgh tarekgh closed this as completed Oct 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged label Oct 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

3 participants