Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precedence between main arguments and advancedSettings #1639

Closed
rogancarr opened this issue Nov 15, 2018 · 2 comments
Closed

Precedence between main arguments and advancedSettings #1639

rogancarr opened this issue Nov 15, 2018 · 2 comments
Labels
question Further information is requested usability Smoothing user interaction or experience

Comments

@rogancarr
Copy link
Contributor

In some learnings, for example GAM, the APIs specify a set of default values, with an optional advanced settings argument.

Oftentimes, as is the case with GAMs, this means that there are two ways to specify the value for a parameter -- as a main line item, or in the advanced settings. In the GAM code, the main line items are applied, followed by the advanced settings. There is no normalization that occurs., meaning that options in the advanced settings can override options set in the main line items.

Is there supposed to be precedence here, or is there any way to make the APIs simpler so that there is only one way to specify a parameter? I'd love to hear people's thoughts on this.

I don't know of any bugs caused by this, but this seems like the kind of thing that can cause unintentional behavior.

@rogancarr rogancarr added question Further information is requested usability Smoothing user interaction or experience labels Nov 15, 2018
@TomFinley
Copy link
Contributor

Hi @rogancarr , sorry this somehow got missed. I ran across this issue while searching for another issue. FYI we are trying to fix this in #1798, so it should be fixed for v1, I hope. (As linked in this issue, the problem you note was also feedback we received from .NET team.)

@rogancarr
Copy link
Contributor Author

Hi @TomFinley ! Great. I'll close this issue for now, then if it's being tracked elsewhere.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested usability Smoothing user interaction or experience
Projects
None yet
Development

No branches or pull requests

2 participants