Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting SDCA multiclass weights requires using a MulticlassLogisticRegressionPredictor, which is strange #1100

Closed
GalOshri opened this issue Sep 29, 2018 · 1 comment · Fixed by #2976
Assignees
Labels
API Issues pertaining the friendly API up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@GalOshri
Copy link
Contributor

As shown here, getting the predictor weights from multiclass-SDCA requires using MulticlassLogisticRegressionPredictor. This is counter-intuitive as I would expect that predictor to be used just for Logistic Regression. Perhaps something more general like MulticlassLinearPredictor should be created/used?

@Ivanidzo4ka Ivanidzo4ka added API Issues pertaining the friendly API up-for-grabs A good issue to fix if you are trying to contribute to the project nit Needs a really small fix labels Oct 19, 2018
@wschin wschin self-assigned this Feb 22, 2019
@wschin
Copy link
Member

wschin commented Feb 22, 2019

Looks like MulticlassLogisticRegressionPredictor should be split into two classes, MulticlassLogisticRegressionPredictor and MulticlassLinearPredictor. SDCA always producing MLRP is obvious wrong because multi-class support vector machine is not multi-class logistic regression. cc @TomFinley.

@shauheen shauheen removed the nit Needs a really small fix label Mar 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants