AD0001: Analyzer 'ILLink.RoslynAnalyzer.RequiresUnreferencedCodeAnalyzer' threw an exception of type 'System.InvalidCastException'

[Sergio0694]

Analyzer

Diagnostic ID: AD0001.

Analyzer source

SDK: .NET 6.0.2 SDK, using VS 17.1

Describe the bug

Building a solution after updating to VS17.1 causes the following issue:

"CSC : error AD0001: Analyzer 'ILLink.RoslynAnalyzer.RequiresUnreferencedCodeAnalyzer' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.TypeParameterSymbol' to type 'Microsoft.CodeAnalysis.INamedTypeSymbol'.'."

This used to work fine on VS 17.0 up to until a few days ago. Our CI also started failing as soon as the image was updated.

https://github.com/CommunityToolkit/dotnet/pull/121/checks?check_run_id=5287917761

Steps To Reproduce

1. Checkout to Fix analyzer build warnings/errors CommunityToolkit/dotnet#121 (CommunityToolkit/dotnet@71ad82d)
2. Build the solution

Expected behavior

Should build fine.

Actual behavior

There is a build warning with the message mentioned above.

[mavasani]

@agocke is this analyzer owned by your team?

[marek-safar]

Seems like another servicing regression?

[agocke]

17.1 brings in 6.0.2xx, so this might be from changes in there. @sbomer does this look familiar?

[sbomer]

This looks like the crash you fixed in 42c199a (that seems to be the only place with a suspicious cast to INamedTypeSymbol in 6.0.2xx). Should we take that part of the fix into a servicing branch?

[agocke]

Confirmed the problem, this was fixed in my bootstrap PR, but wasn't backported to 6.0.2xx https://github.com/dotnet/linker/pull/2540/files

[agocke]

Yeah, we should bring that fix to the servicing branch.

[sbomer]

Already fixed in main, and #2643 fixes this in 6.0.2.

[nagya]

Already fixed in main, and #2643 fixes this in 6.0.2.

@sbomer, a duplicate of this continues to repro in 6.0.201.

[sbomer]

Sorry @nagya, it looks like the fix wasn't made in time for that patch release. Currently it's waiting on dependency flow from dotnet/sdk into dotnet/installer: dotnet/installer#13394. Thank you for following up on this.

[RealDotNetDave]

I am having the same issue. When will this be fixed since I can't compile my assembly??

[agocke]

Patch releases for .NET are every patch Tuesday, so our next update is April 12th. However, this should already be fixed in preview, so if you install the .NET 7 preview release, you should see the fix.

Alternatively, you can temporarily disable trim warnings by setting <EnableTrimAnalyzer>false</EnableTrimAnalyzer>