Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cells use notebook default language instead of previous cell language #2794

Open
jonsequitur opened this issue Mar 3, 2023 · 5 comments · Fixed by #2796
Open

New cells use notebook default language instead of previous cell language #2794

jonsequitur opened this issue Mar 3, 2023 · 5 comments · Fixed by #2796

Comments

@jonsequitur
Copy link
Contributor

jonsequitur commented Mar 3, 2023

When creating a new cell, the default language is the notebook's default language.

It is expected to be the same language as the previous cell, e.g. in the following screen shot in a notebook whose default language was set to C#, the second cell should be javascript.

image

Related: #2752, #2762

@ocallesp
Copy link
Contributor

ocallesp commented Mar 6, 2023

Hi @jonsequitur

I couldn't repro this issue (animated gif below). Did I miss a step?
github-2794-cannot-repro

@AbhitejJohn
Copy link
Contributor

@ocallesp : You'd likely want to create a C# cell after the first js cell and then create a new cell after that. The 3rd cell should be C# and not js.

@jonsequitur
Copy link
Contributor Author

I updated the issue description to be hopefully a little clearer.

@ocallesp ocallesp assigned brettfo and unassigned ocallesp Mar 6, 2023
@ocallesp
Copy link
Contributor

ocallesp commented Mar 6, 2023

Assigned this issue to @brettfo since he already has a PR ready for review.
github-2794-repro

@jonsequitur
Copy link
Contributor Author

This issue is regressed. I noticed it in the following extension version:

Version: 1.0.520801+1e5d205f82c7f5bb1b2e5ce60c680491552cfa23
Library version: 1.0.0-beta.24208.1+1e5d205f82c7f5bb1b2e5ce60c680491552cfa23
Build date: 2024-04-09T18:58:49.1321131Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants