From 21fd0c6aed65736dfc90ad69955727980bce7be2 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Wed, 16 Nov 2022 00:09:03 +0000 Subject: [PATCH] [main] Update dependencies from dotnet/arcade (#2374) [main] Update dependencies from dotnet/arcade - update to run on dotnet 7 - update to stable sdk - update mime type to align with new value The default MIME type for `.js` files changed to `text/javascript` in dotnet/aspnetcore#40771 so the test needed to be updated, too. - update minimum sdk version for vscode extension - Merge remote-tracking branch 'upstream/main' into darc-main-f75372cd-0832-40a1-95fc-5022c8550314 - update test package versions - add linux test retry - don't fail build on docker build failures - update test command - run tests one assembly at a time - update extension lab packages - skip ildasm test - improve log message - log errors - run tests on a class-by-class basis --- .devcontainer/devcontainer.json | 10 +- DEVELOPER-GUIDE.md | 4 +- Directory.Build.props | 4 +- Directory.Build.targets | 4 +- NuGet.config | 2 +- Running a .NET 6 kernel.md | 80 ----- azure-pipelines.yml | 102 +++++- eng/AfterSolutionBuild.targets | 4 +- eng/Version.Details.xml | 4 +- eng/common/SetupNugetSources.ps1 | 18 +- eng/common/SetupNugetSources.sh | 68 ++-- eng/common/build.ps1 | 5 + eng/common/build.sh | 17 +- eng/common/cross/armel/tizen-fetch.sh | 8 +- eng/common/cross/armel/tizen/tizen-dotnet.ks | 50 --- eng/common/cross/build-android-rootfs.sh | 4 +- eng/common/cross/build-rootfs.sh | 335 ++++++++++++------ eng/common/cross/riscv64/sources.list.sid | 1 + eng/common/cross/toolchain.cmake | 98 +++-- eng/common/generate-locproject.ps1 | 47 ++- eng/common/generate-sbom-prep.ps1 | 2 + eng/common/generate-sbom-prep.sh | 12 + eng/common/init-tools-native.ps1 | 10 +- eng/common/native/init-compiler.sh | 2 +- eng/common/sdk-task.ps1 | 2 +- eng/common/sdl/NuGet.config | 5 + eng/common/sdl/sdl.ps1 | 38 ++ eng/common/templates/job/execute-sdl.yml | 9 +- eng/common/templates/job/job.yml | 41 +-- eng/common/templates/job/onelocbuild.yml | 29 +- .../templates/job/publish-build-assets.yml | 13 +- eng/common/templates/job/source-build.yml | 15 +- .../templates/job/source-index-stage1.yml | 7 +- eng/common/templates/jobs/jobs.yml | 9 - eng/common/templates/jobs/source-build.yml | 2 +- .../templates/post-build/post-build.yml | 16 +- eng/common/templates/steps/execute-sdl.yml | 60 ++-- eng/common/templates/steps/generate-sbom.yml | 4 + eng/common/templates/steps/send-to-helix.yml | 10 +- eng/common/templates/steps/source-build.yml | 14 +- .../templates/variables/pool-providers.yml | 48 +++ eng/common/tools.ps1 | 17 +- eng/common/tools.sh | 24 +- eng/perf-tests/perf-tests.csproj | 2 +- global.json | 6 +- samples/connect-wpf/WpfConnect.csproj | 2 +- .../ClockExtension/ClockExtension.csproj | 2 +- .../Library.InteractiveExtension.csproj | 2 +- .../Library.nuget/Library.nuget.csproj | 2 +- samples/extensions/Library/Library.csproj | 2 +- .../SampleExtensions.Tests.csproj | 6 +- .../FSharpConsole.csproj | 2 +- ....Interactive.ApiCompatibility.Tests.csproj | 4 +- ...DotNet.Interactive.AspNetCore.Tests.csproj | 4 +- ...osoft.DotNet.Interactive.AspNetCore.csproj | 2 +- ...ft.DotNet.Interactive.Browser.Tests.csproj | 4 +- ...icrosoft.DotNet.Interactive.Browser.csproj | 2 +- ...oft.DotNet.Interactive.CSharp.Tests.csproj | 4 +- ...Net.Interactive.CSharpProject.Tests.csproj | 4 +- .../SampleConsole/BasicConsoleApp.csproj | 2 +- ...ft.DotNet.Interactive.CSharpProject.csproj | 2 +- ....DotNet.Interactive.Documents.Tests.csproj | 4 +- .../InspectTests.cs | 2 +- ...tNet.Interactive.ExtensionLab.Tests.csproj | 4 +- .../Inspector/Defaults.cs | 2 +- .../JitAsmDecompiler/JitAsmDecompiler.cs | 25 +- .../JitAsmDecompiler/JitAsmSymbolResolver.cs | 4 +- ...oft.DotNet.Interactive.ExtensionLab.csproj | 14 +- ...oft.DotNet.Interactive.FSharp.Tests.fsproj | 4 +- ...Microsoft.DotNet.Interactive.FSharp.fsproj | 2 +- ...DotNet.Interactive.Formatting.Tests.csproj | 4 +- .../Microsoft.DotNet.Interactive.Http.csproj | 2 +- ...ft.DotNet.Interactive.Journey.Tests.csproj | 4 +- .../MagicCommandTests.lsmagic.cs | 2 +- .../MagicCommandTests.markdown.cs | 2 +- .../MagicCommandTests.time.cs | 2 +- ...ft.DotNet.Interactive.Jupyter.Tests.csproj | 4 +- ...icrosoft.DotNet.Interactive.Jupyter.csproj | 2 +- .../RequestHandlerBase.cs | 15 +- .../ZMQ/SignatureValidator.cs | 2 +- ...rosoft.DotNet.Interactive.Kql.Tests.csproj | 4 +- .../Microsoft.DotNet.Interactive.Kql.csproj | 2 +- ...ft.DotNet.Interactive.Mermaid.Tests.csproj | 4 +- ...icrosoft.DotNet.Interactive.Mermaid.csproj | 2 +- .../PackageRestoreContext.cs | 14 +- ...DotNet.Interactive.PowerShell.Tests.csproj | 4 +- ...osoft.DotNet.Interactive.PowerShell.csproj | 2 +- ....DotNet.Interactive.SqlServer.Tests.csproj | 4 +- ...rosoft.DotNet.Interactive.SqlServer.csproj | 4 +- ....DotNet.Interactive.Telemetry.Tests.csproj | 4 +- ...rosoft.DotNet.Interactive.Telemetry.csproj | 2 +- .../Microsoft.DotNet.Interactive.Tests.csproj | 4 +- .../Utility/KernelExtensionTestHelper.cs | 8 +- ...Microsoft.DotNet.Interactive.VSCode.csproj | 2 +- .../KernelHost.cs | 11 +- .../src/extension.ts | 2 +- .../package.json | 2 +- src/dotnet-interactive-vscode/package.json | 2 +- src/dotnet-interactive.Tests/HttpApiTests.cs | 2 +- .../MagicCommandTests.about.cs | 4 +- .../dotnet-interactive.Tests.csproj | 4 +- .../dotnet-interactive.csproj | 2 +- .../interface-generator.csproj | 2 +- 103 files changed, 914 insertions(+), 585 deletions(-) delete mode 100644 Running a .NET 6 kernel.md delete mode 100644 eng/common/cross/armel/tizen/tizen-dotnet.ks create mode 100644 eng/common/cross/riscv64/sources.list.sid create mode 100644 eng/common/sdl/sdl.ps1 create mode 100644 eng/common/templates/variables/pool-providers.yml diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 39f7c9d21c..3e8b6819aa 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -7,7 +7,7 @@ "args": { // Update 'VARIANT' to pick a .NET Core version: 3.1, 5.0, 6.0 // Append -bullseye or -focal to pin to an OS version. - "VARIANT": "6.0", + "VARIANT": "7.0", // Options "NODE_VERSION": "16" } @@ -16,7 +16,7 @@ "settings": { "dotnet-interactive.kernelTransportArgs": [ "{dotnet_path}", - "/workspaces/interactive/artifacts/bin/dotnet-interactive/Debug/net6.0/Microsoft.DotNet.Interactive.App.dll", + "/workspaces/interactive/artifacts/bin/dotnet-interactive/Debug/net7.0/Microsoft.DotNet.Interactive.App.dll", "[vscode]", "stdio", "--working-dir", @@ -24,11 +24,11 @@ ], "dotnet-interactive.notebookParserArgs": [ "{dotnet_path}", - "/workspaces/interactive/artifacts/bin/dotnet-interactive/Debug/net6.0/Microsoft.DotNet.Interactive.App.dll", + "/workspaces/interactive/artifacts/bin/dotnet-interactive/Debug/net7.0/Microsoft.DotNet.Interactive.App.dll", "notebook-parser" ], "editor.formatOnSave": true, - "files.trimTrailingWhitespace": true, + "files.trimTrailingWhitespace": true }, // Add the IDs of extensions you want installed when the container is created. "extensions": [ @@ -73,4 +73,4 @@ "features": { "powershell": "latest" } -} +} \ No newline at end of file diff --git a/DEVELOPER-GUIDE.md b/DEVELOPER-GUIDE.md index 70aa749434..4a104fb6e7 100644 --- a/DEVELOPER-GUIDE.md +++ b/DEVELOPER-GUIDE.md @@ -113,7 +113,7 @@ If you've made changes to `dotnet-interactive` and want to try them out with Vis ```js "dotnet-interactive.kernelTransportArgs": [ "{dotnet_path}", - "/PATH/TO/REPO/ROOT/artifacts/bin/dotnet-interactive/Debug/net6.0/Microsoft.DotNet.Interactive.App.dll", + "/PATH/TO/REPO/ROOT/artifacts/bin/dotnet-interactive/Debug/net7.0/Microsoft.DotNet.Interactive.App.dll", "[vscode]", "stdio", "--log-path", @@ -125,7 +125,7 @@ If you've made changes to `dotnet-interactive` and want to try them out with Vis "dotnet-interactive.notebookParserArgs": [ "{dotnet_path}", - "/PATH/TO/REPO/ROOT/artifacts/bin/dotnet-interactive/Debug/net6.0/Microsoft.DotNet.Interactive.App.dll", + "/PATH/TO/REPO/ROOT/artifacts/bin/dotnet-interactive/Debug/net7.0/Microsoft.DotNet.Interactive.App.dll", "notebook-parser" ] ``` diff --git a/Directory.Build.props b/Directory.Build.props index 30e6834793..ca85a4b0a7 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -15,11 +15,13 @@ - 17.2.0 + 17.4.0 13.0.1 4.2.0 5.0.0 6.0.1 + 2.4.2 + 2.4.5 diff --git a/Directory.Build.targets b/Directory.Build.targets index 230e05d161..a8a0c78df5 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -10,8 +10,8 @@ - - + + $(NoWarn);8002 @@ -37,7 +37,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.AspNetCore.Tests/Microsoft.DotNet.Interactive.AspNetCore.Tests.csproj b/src/Microsoft.DotNet.Interactive.AspNetCore.Tests/Microsoft.DotNet.Interactive.AspNetCore.Tests.csproj index 4f60853b61..d0dc157dd6 100644 --- a/src/Microsoft.DotNet.Interactive.AspNetCore.Tests/Microsoft.DotNet.Interactive.AspNetCore.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.AspNetCore.Tests/Microsoft.DotNet.Interactive.AspNetCore.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 $(NoWarn);VSTHRD200 @@ -30,7 +30,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.AspNetCore/Microsoft.DotNet.Interactive.AspNetCore.csproj b/src/Microsoft.DotNet.Interactive.AspNetCore/Microsoft.DotNet.Interactive.AspNetCore.csproj index 1e1af39776..c32f6b714b 100644 --- a/src/Microsoft.DotNet.Interactive.AspNetCore/Microsoft.DotNet.Interactive.AspNetCore.csproj +++ b/src/Microsoft.DotNet.Interactive.AspNetCore/Microsoft.DotNet.Interactive.AspNetCore.csproj @@ -1,7 +1,7 @@ - net6.0 + net7.0 Library diff --git a/src/Microsoft.DotNet.Interactive.Browser.Tests/Microsoft.DotNet.Interactive.Browser.Tests.csproj b/src/Microsoft.DotNet.Interactive.Browser.Tests/Microsoft.DotNet.Interactive.Browser.Tests.csproj index a543678a6c..68c5cf845c 100644 --- a/src/Microsoft.DotNet.Interactive.Browser.Tests/Microsoft.DotNet.Interactive.Browser.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Browser.Tests/Microsoft.DotNet.Interactive.Browser.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 preview $(NoWarn);8002;VSTHRD002;VSTHRD200 @@ -39,7 +39,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Browser/Microsoft.DotNet.Interactive.Browser.csproj b/src/Microsoft.DotNet.Interactive.Browser/Microsoft.DotNet.Interactive.Browser.csproj index fe79c0ef86..bd030dc7e0 100644 --- a/src/Microsoft.DotNet.Interactive.Browser/Microsoft.DotNet.Interactive.Browser.csproj +++ b/src/Microsoft.DotNet.Interactive.Browser/Microsoft.DotNet.Interactive.Browser.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 enable enable diff --git a/src/Microsoft.DotNet.Interactive.CSharp.Tests/Microsoft.DotNet.Interactive.CSharp.Tests.csproj b/src/Microsoft.DotNet.Interactive.CSharp.Tests/Microsoft.DotNet.Interactive.CSharp.Tests.csproj index 99ae64e574..0fe34abbc1 100644 --- a/src/Microsoft.DotNet.Interactive.CSharp.Tests/Microsoft.DotNet.Interactive.CSharp.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.CSharp.Tests/Microsoft.DotNet.Interactive.CSharp.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 false $(NoWarn);VSTHRD200 @@ -34,7 +34,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/Microsoft.DotNet.Interactive.CSharpProject.Tests.csproj b/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/Microsoft.DotNet.Interactive.CSharpProject.Tests.csproj index 36bbf587dd..73bba873cc 100644 --- a/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/Microsoft.DotNet.Interactive.CSharpProject.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/Microsoft.DotNet.Interactive.CSharpProject.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 portable-net45+win8+wp8+wpa81 $(NoWarn);VSTHRD002 $(NoWarn);VSTHRD100 @@ -89,7 +89,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/TestProjects/SampleConsole/BasicConsoleApp.csproj b/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/TestProjects/SampleConsole/BasicConsoleApp.csproj index ddb344e65f..3370449d17 100644 --- a/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/TestProjects/SampleConsole/BasicConsoleApp.csproj +++ b/src/Microsoft.DotNet.Interactive.CSharpProject.Tests/TestProjects/SampleConsole/BasicConsoleApp.csproj @@ -2,7 +2,7 @@ Exe - net6.0 + net7.0 diff --git a/src/Microsoft.DotNet.Interactive.CSharpProject/Microsoft.DotNet.Interactive.CSharpProject.csproj b/src/Microsoft.DotNet.Interactive.CSharpProject/Microsoft.DotNet.Interactive.CSharpProject.csproj index ae40eec384..e82bfb979e 100644 --- a/src/Microsoft.DotNet.Interactive.CSharpProject/Microsoft.DotNet.Interactive.CSharpProject.csproj +++ b/src/Microsoft.DotNet.Interactive.CSharpProject/Microsoft.DotNet.Interactive.CSharpProject.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 Latest $(AssetTargetFallback);dotnet5.4;portable-net45+win8 preview diff --git a/src/Microsoft.DotNet.Interactive.Documents.Tests/Microsoft.DotNet.Interactive.Documents.Tests.csproj b/src/Microsoft.DotNet.Interactive.Documents.Tests/Microsoft.DotNet.Interactive.Documents.Tests.csproj index 7ef76875d8..bcf13b4c0c 100644 --- a/src/Microsoft.DotNet.Interactive.Documents.Tests/Microsoft.DotNet.Interactive.Documents.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Documents.Tests/Microsoft.DotNet.Interactive.Documents.Tests.csproj @@ -1,7 +1,7 @@ - net6.0 + net7.0 $(NoWarn);8002 $(NoWarn);VSTHRD200 $(NoWarn);CS8509 @@ -32,7 +32,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/Defaults.cs b/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/Defaults.cs index 5935957f06..ed0c0ce50b 100644 --- a/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/Defaults.cs +++ b/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/Defaults.cs @@ -20,7 +20,7 @@ internal static class Defaults internal static readonly Pool DefaultRuntimePool = new Pool(() => { using var currentProcess = Process.GetCurrentProcess(); - var dataTarget = DataTarget.AttachToProcess(currentProcess.Id, uint.MaxValue, AttachFlag.Passive); + var dataTarget = DataTarget.AttachToProcess(currentProcess.Id, suspend: false); return dataTarget.ClrVersions.Single(c => c.Flavor == ClrFlavor.Core).CreateRuntime(); }); diff --git a/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmDecompiler.cs b/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmDecompiler.cs index 3c820dbc5f..0d69b531a9 100644 --- a/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmDecompiler.cs +++ b/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmDecompiler.cs @@ -29,6 +29,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE using System.Linq; using System.Reflection; using System.Runtime.CompilerServices; +using System.Runtime.InteropServices; using Iced.Intel; @@ -76,7 +77,7 @@ private void Decompile(Stream dll, TextWriter codeWriter) using var runtimeLease = _runtimePool.GetOrCreate(); var runtime = runtimeLease.Object; - runtime.Flush(); + runtime.FlushCachedData(); var context = new JitWriteContext(codeWriter, runtime); @@ -106,7 +107,7 @@ private void WriteJitInfo(ClrInfo clr, TextWriter writer) { writer.WriteLine( "; {0:G} CLR {1} on {2}", - clr.Flavor, clr.Version, clr.DacInfo.TargetArchitecture.ToString("G").ToLowerInvariant() + clr.Flavor, clr.Version, clr.DebuggingLibraries.First().TargetArchitecture.ToString("G").ToLowerInvariant() ); } @@ -184,7 +185,7 @@ private void DisassembleAndWriteSimpleMethod(JitWriteContext context, MethodBase if (clrMethod is null || regions is null) { - context.Runtime.Flush(); + context.Runtime.FlushCachedData(); clrMethod = context.Runtime.GetMethodByHandle((ulong)handle.Value.ToInt64()); regions = FindNonEmptyHotColdInfo(clrMethod); } @@ -192,7 +193,7 @@ private void DisassembleAndWriteSimpleMethod(JitWriteContext context, MethodBase if (clrMethod is null || regions is null) { var address = (ulong)handle.GetFunctionPointer().ToInt64(); - clrMethod = context.Runtime.GetMethodByAddress(address); + clrMethod = context.Runtime.GetMethodByInstructionPointer(address); regions = FindNonEmptyHotColdInfo(clrMethod); } @@ -200,7 +201,7 @@ private void DisassembleAndWriteSimpleMethod(JitWriteContext context, MethodBase if (clrMethod is not null) { writer.WriteLine(); - writer.WriteLine(clrMethod.GetFullSignature()); + writer.WriteLine(clrMethod.Signature); } else { @@ -218,11 +219,11 @@ private void DisassembleAndWriteSimpleMethod(JitWriteContext context, MethodBase return; } - var methodAddress = regions.HotStart; - var methodLength = regions.HotSize; + var methodAddress = regions.Value.HotStart; + var methodLength = regions.Value.HotSize; var reader = new MemoryCodeReader(new IntPtr(unchecked((long)methodAddress)), methodLength); - var decoder = Decoder.Create(MapArchitectureToBitness(context.Runtime.DataTarget.Architecture), reader); + var decoder = Decoder.Create(MapArchitectureToBitness(context.Runtime.DataTarget.DataReader.Architecture), reader); var instructions = new InstructionList(); decoder.IP = methodAddress; @@ -262,7 +263,7 @@ private static void WriteSignatureFromReflection(JitWriteContext context, Method context.Writer.WriteLine(signature ?? "Unknown Method"); } - private HotColdRegions FindNonEmptyHotColdInfo(ClrMethod method) + private HotColdRegions? FindNonEmptyHotColdInfo(ClrMethod method) { if (method is null) return null; @@ -276,10 +277,10 @@ private HotColdRegions FindNonEmptyHotColdInfo(ClrMethod method) if (method.Type is null) return null; - var methodSignature = method.GetFullSignature(); + var methodSignature = method.Signature; foreach (var other in method.Type.Methods) { - if (other.MetadataToken == method.MetadataToken && other.GetFullSignature() == methodSignature && other.HotColdInfo.HotSize > 0) + if (other.MetadataToken == method.MetadataToken && other.Signature == methodSignature && other.HotColdInfo.HotSize > 0) return other.HotColdInfo; } @@ -288,7 +289,7 @@ private HotColdRegions FindNonEmptyHotColdInfo(ClrMethod method) private int MapArchitectureToBitness(Architecture architecture) => architecture switch { - Architecture.Amd64 => 64, + Architecture.X64 => 64, Architecture.X86 => 32, _ => throw new Exception($"Unsupported architecture {architecture}.") }; diff --git a/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmSymbolResolver.cs b/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmSymbolResolver.cs index e3a1400382..99692db294 100644 --- a/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmSymbolResolver.cs +++ b/src/Microsoft.DotNet.Interactive.ExtensionLab/Inspector/JitAsmDecompiler/JitAsmSymbolResolver.cs @@ -51,14 +51,14 @@ public bool TryGetSymbol(in Instruction instruction, int operand, int instructio return true; } - var method = _runtime.GetMethodByAddress(address); + var method = _runtime.GetMethodByInstructionPointer(address); if (method is null) { symbol = default; return false; } - symbol = new SymbolResult(address, method.GetFullSignature()); + symbol = new SymbolResult(address, method.Signature); return true; } } diff --git a/src/Microsoft.DotNet.Interactive.ExtensionLab/Microsoft.DotNet.Interactive.ExtensionLab.csproj b/src/Microsoft.DotNet.Interactive.ExtensionLab/Microsoft.DotNet.Interactive.ExtensionLab.csproj index 404b7a6875..7e9a446692 100644 --- a/src/Microsoft.DotNet.Interactive.ExtensionLab/Microsoft.DotNet.Interactive.ExtensionLab.csproj +++ b/src/Microsoft.DotNet.Interactive.ExtensionLab/Microsoft.DotNet.Interactive.ExtensionLab.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 Library @@ -24,12 +24,12 @@ - - - - + + + + - + @@ -40,7 +40,7 @@ - + diff --git a/src/Microsoft.DotNet.Interactive.FSharp.Tests/Microsoft.DotNet.Interactive.FSharp.Tests.fsproj b/src/Microsoft.DotNet.Interactive.FSharp.Tests/Microsoft.DotNet.Interactive.FSharp.Tests.fsproj index 5560bec6e9..5dce1917be 100644 --- a/src/Microsoft.DotNet.Interactive.FSharp.Tests/Microsoft.DotNet.Interactive.FSharp.Tests.fsproj +++ b/src/Microsoft.DotNet.Interactive.FSharp.Tests/Microsoft.DotNet.Interactive.FSharp.Tests.fsproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 false @@ -28,7 +28,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.FSharp/Microsoft.DotNet.Interactive.FSharp.fsproj b/src/Microsoft.DotNet.Interactive.FSharp/Microsoft.DotNet.Interactive.FSharp.fsproj index 4b1c5a4c65..a15ec068df 100644 --- a/src/Microsoft.DotNet.Interactive.FSharp/Microsoft.DotNet.Interactive.FSharp.fsproj +++ b/src/Microsoft.DotNet.Interactive.FSharp/Microsoft.DotNet.Interactive.FSharp.fsproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 $(NoWarn);2003;57 false preview diff --git a/src/Microsoft.DotNet.Interactive.Formatting.Tests/Microsoft.DotNet.Interactive.Formatting.Tests.csproj b/src/Microsoft.DotNet.Interactive.Formatting.Tests/Microsoft.DotNet.Interactive.Formatting.Tests.csproj index 99273a5d00..fad108bdfd 100644 --- a/src/Microsoft.DotNet.Interactive.Formatting.Tests/Microsoft.DotNet.Interactive.Formatting.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Formatting.Tests/Microsoft.DotNet.Interactive.Formatting.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 false $(NoWarn);8002 @@ -33,7 +33,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Http/Microsoft.DotNet.Interactive.Http.csproj b/src/Microsoft.DotNet.Interactive.Http/Microsoft.DotNet.Interactive.Http.csproj index c3173fb1f8..4b9f7e8abb 100644 --- a/src/Microsoft.DotNet.Interactive.Http/Microsoft.DotNet.Interactive.Http.csproj +++ b/src/Microsoft.DotNet.Interactive.Http/Microsoft.DotNet.Interactive.Http.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 diff --git a/src/Microsoft.DotNet.Interactive.Journey.Tests/Microsoft.DotNet.Interactive.Journey.Tests.csproj b/src/Microsoft.DotNet.Interactive.Journey.Tests/Microsoft.DotNet.Interactive.Journey.Tests.csproj index d56f51c4a1..15382a5cec 100644 --- a/src/Microsoft.DotNet.Interactive.Journey.Tests/Microsoft.DotNet.Interactive.Journey.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Journey.Tests/Microsoft.DotNet.Interactive.Journey.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 false $(NoWarn);8002 $(NoWarn);VSTHRD002 @@ -22,7 +22,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.lsmagic.cs b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.lsmagic.cs index 4386f19782..746d8d722b 100644 --- a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.lsmagic.cs +++ b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.lsmagic.cs @@ -17,7 +17,7 @@ namespace Microsoft.DotNet.Interactive.Jupyter.Tests { public partial class MagicCommandTests { - public class lsmagic + public class LSMmagic { [Fact] public async Task lsmagic_lists_registered_magic_commands() diff --git a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.markdown.cs b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.markdown.cs index cbf5f82eb8..c59b3f667c 100644 --- a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.markdown.cs +++ b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.markdown.cs @@ -14,7 +14,7 @@ namespace Microsoft.DotNet.Interactive.Jupyter.Tests { public partial class MagicCommandTests { - public class markdown + public class Markdown { [Fact] public async Task markdown_renders_markdown_content_as_html() diff --git a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.time.cs b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.time.cs index 527ce4ef78..da908d52f9 100644 --- a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.time.cs +++ b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/MagicCommandTests.time.cs @@ -15,7 +15,7 @@ namespace Microsoft.DotNet.Interactive.Jupyter.Tests { public partial class MagicCommandTests { - public class time + public class Time { [Fact] public async Task time_produces_time_elapsed_to_run_the_code_submission() diff --git a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/Microsoft.DotNet.Interactive.Jupyter.Tests.csproj b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/Microsoft.DotNet.Interactive.Jupyter.Tests.csproj index 1c4c7bb8e9..d225031094 100644 --- a/src/Microsoft.DotNet.Interactive.Jupyter.Tests/Microsoft.DotNet.Interactive.Jupyter.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Jupyter.Tests/Microsoft.DotNet.Interactive.Jupyter.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 latest portable-net45+win8+wp8+wpa81 $(NoWarn);8002 @@ -46,7 +46,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Jupyter/Microsoft.DotNet.Interactive.Jupyter.csproj b/src/Microsoft.DotNet.Interactive.Jupyter/Microsoft.DotNet.Interactive.Jupyter.csproj index 779d36768b..a586bbb55d 100644 --- a/src/Microsoft.DotNet.Interactive.Jupyter/Microsoft.DotNet.Interactive.Jupyter.csproj +++ b/src/Microsoft.DotNet.Interactive.Jupyter/Microsoft.DotNet.Interactive.Jupyter.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 latest diff --git a/src/Microsoft.DotNet.Interactive.Jupyter/RequestHandlerBase.cs b/src/Microsoft.DotNet.Interactive.Jupyter/RequestHandlerBase.cs index e4bc7327b0..612fa642d5 100644 --- a/src/Microsoft.DotNet.Interactive.Jupyter/RequestHandlerBase.cs +++ b/src/Microsoft.DotNet.Interactive.Jupyter/RequestHandlerBase.cs @@ -10,6 +10,7 @@ using Microsoft.DotNet.Interactive.Commands; using Microsoft.DotNet.Interactive.Events; using Microsoft.DotNet.Interactive.Jupyter.Protocol; +using Pocket; namespace Microsoft.DotNet.Interactive.Jupyter { @@ -35,7 +36,17 @@ protected async Task SendAsync( using var sub = Kernel .KernelEvents .Where(ShouldForward) - .Subscribe(e => OnKernelEventReceived(e, context)); + .Subscribe(e => + { + try + { + OnKernelEventReceived(e, context); + } + catch (Exception ex) + { + Logger.Log.Error(ex); + } + }); await Kernel.SendAsync( command, @@ -66,4 +77,4 @@ public void Dispose() _disposables.Dispose(); } } -} \ No newline at end of file +} diff --git a/src/Microsoft.DotNet.Interactive.Jupyter/ZMQ/SignatureValidator.cs b/src/Microsoft.DotNet.Interactive.Jupyter/ZMQ/SignatureValidator.cs index 8b90ee6055..99fad7f827 100644 --- a/src/Microsoft.DotNet.Interactive.Jupyter/ZMQ/SignatureValidator.cs +++ b/src/Microsoft.DotNet.Interactive.Jupyter/ZMQ/SignatureValidator.cs @@ -18,7 +18,7 @@ public class SignatureValidator public SignatureValidator(string key, string algorithm) { _encoder = new UTF8Encoding(); - _signatureGenerator = HMAC.Create(algorithm); + _signatureGenerator = (HMAC)CryptoConfig.CreateFromName(algorithm); _signatureGenerator.Key = _encoder.GetBytes(key); } diff --git a/src/Microsoft.DotNet.Interactive.Kql.Tests/Microsoft.DotNet.Interactive.Kql.Tests.csproj b/src/Microsoft.DotNet.Interactive.Kql.Tests/Microsoft.DotNet.Interactive.Kql.Tests.csproj index 7794f7d023..2a8131e476 100644 --- a/src/Microsoft.DotNet.Interactive.Kql.Tests/Microsoft.DotNet.Interactive.Kql.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Kql.Tests/Microsoft.DotNet.Interactive.Kql.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 preview $(NoWarn);8002;VSTHRD002;VSTHRD200 @@ -30,7 +30,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Kql/Microsoft.DotNet.Interactive.Kql.csproj b/src/Microsoft.DotNet.Interactive.Kql/Microsoft.DotNet.Interactive.Kql.csproj index 188d6458f8..1930db1b44 100644 --- a/src/Microsoft.DotNet.Interactive.Kql/Microsoft.DotNet.Interactive.Kql.csproj +++ b/src/Microsoft.DotNet.Interactive.Kql/Microsoft.DotNet.Interactive.Kql.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 Library diff --git a/src/Microsoft.DotNet.Interactive.Mermaid.Tests/Microsoft.DotNet.Interactive.Mermaid.Tests.csproj b/src/Microsoft.DotNet.Interactive.Mermaid.Tests/Microsoft.DotNet.Interactive.Mermaid.Tests.csproj index 461100b247..16b01aeba2 100644 --- a/src/Microsoft.DotNet.Interactive.Mermaid.Tests/Microsoft.DotNet.Interactive.Mermaid.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Mermaid.Tests/Microsoft.DotNet.Interactive.Mermaid.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 preview $(NoWarn);8002;VSTHRD002;VSTHRD200 @@ -26,7 +26,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Mermaid/Microsoft.DotNet.Interactive.Mermaid.csproj b/src/Microsoft.DotNet.Interactive.Mermaid/Microsoft.DotNet.Interactive.Mermaid.csproj index 8e5e6d5d20..64c6f993c1 100644 --- a/src/Microsoft.DotNet.Interactive.Mermaid/Microsoft.DotNet.Interactive.Mermaid.csproj +++ b/src/Microsoft.DotNet.Interactive.Mermaid/Microsoft.DotNet.Interactive.Mermaid.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 enable enable diff --git a/src/Microsoft.DotNet.Interactive.PackageManagement/PackageRestoreContext.cs b/src/Microsoft.DotNet.Interactive.PackageManagement/PackageRestoreContext.cs index 63e2a51090..c7a36cb817 100644 --- a/src/Microsoft.DotNet.Interactive.PackageManagement/PackageRestoreContext.cs +++ b/src/Microsoft.DotNet.Interactive.PackageManagement/PackageRestoreContext.cs @@ -17,7 +17,7 @@ namespace Microsoft.DotNet.Interactive { public class PackageRestoreContext : IDisposable { - private const string restoreTfm = "net6.0"; + private const string restoreTfm = "net7.0"; private readonly ConcurrentDictionary _requestedPackageReferences = new(StringComparer.OrdinalIgnoreCase); private readonly ConcurrentDictionary _resolvedPackageReferences = new(StringComparer.OrdinalIgnoreCase); @@ -224,8 +224,8 @@ private void OnAssemblyLoad(object sender, AssemblyLoadEventArgs args) } private IResolveDependenciesResult Resolve( - IEnumerable> packageManagerTextLines, - string executionTfm, + IEnumerable> packageManagerTextLines, + string executionTfm, ResolvingErrorReport reportError) { IDependencyManagerProvider iDependencyManager = _dependencyProvider.TryFindDependencyManagerByKey(Enumerable.Empty(), "", reportError, "nuget"); @@ -238,10 +238,10 @@ private IResolveDependenciesResult Resolve( } return _dependencyProvider.Resolve( - iDependencyManager, - ".csx", - packageManagerTextLines, - reportError, + iDependencyManager, + ".csx", + packageManagerTextLines, + reportError, executionTfm); } diff --git a/src/Microsoft.DotNet.Interactive.PowerShell.Tests/Microsoft.DotNet.Interactive.PowerShell.Tests.csproj b/src/Microsoft.DotNet.Interactive.PowerShell.Tests/Microsoft.DotNet.Interactive.PowerShell.Tests.csproj index 128d01b24c..6d50665ee6 100644 --- a/src/Microsoft.DotNet.Interactive.PowerShell.Tests/Microsoft.DotNet.Interactive.PowerShell.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.PowerShell.Tests/Microsoft.DotNet.Interactive.PowerShell.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 latest $(NoWarn);8002;CS8002 $(NoWarn);VSTHRD200 @@ -25,7 +25,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.PowerShell/Microsoft.DotNet.Interactive.PowerShell.csproj b/src/Microsoft.DotNet.Interactive.PowerShell/Microsoft.DotNet.Interactive.PowerShell.csproj index b78ea055f1..cb3647a0b1 100644 --- a/src/Microsoft.DotNet.Interactive.PowerShell/Microsoft.DotNet.Interactive.PowerShell.csproj +++ b/src/Microsoft.DotNet.Interactive.PowerShell/Microsoft.DotNet.Interactive.PowerShell.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 latest $(NoWarn);2003;CS8002;NU1608; $(NoWarn);NU5100 diff --git a/src/Microsoft.DotNet.Interactive.SqlServer.Tests/Microsoft.DotNet.Interactive.SqlServer.Tests.csproj b/src/Microsoft.DotNet.Interactive.SqlServer.Tests/Microsoft.DotNet.Interactive.SqlServer.Tests.csproj index 8e6de1cccf..7a9d094b55 100644 --- a/src/Microsoft.DotNet.Interactive.SqlServer.Tests/Microsoft.DotNet.Interactive.SqlServer.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.SqlServer.Tests/Microsoft.DotNet.Interactive.SqlServer.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 preview $(NoWarn);8002;VSTHRD002;VSTHRD200 @@ -31,7 +31,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.SqlServer/Microsoft.DotNet.Interactive.SqlServer.csproj b/src/Microsoft.DotNet.Interactive.SqlServer/Microsoft.DotNet.Interactive.SqlServer.csproj index fc5b595543..38d6c3d36c 100644 --- a/src/Microsoft.DotNet.Interactive.SqlServer/Microsoft.DotNet.Interactive.SqlServer.csproj +++ b/src/Microsoft.DotNet.Interactive.SqlServer/Microsoft.DotNet.Interactive.SqlServer.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 Library @@ -42,7 +42,7 @@ - + diff --git a/src/Microsoft.DotNet.Interactive.Telemetry.Tests/Microsoft.DotNet.Interactive.Telemetry.Tests.csproj b/src/Microsoft.DotNet.Interactive.Telemetry.Tests/Microsoft.DotNet.Interactive.Telemetry.Tests.csproj index cb59a22030..abd369707b 100644 --- a/src/Microsoft.DotNet.Interactive.Telemetry.Tests/Microsoft.DotNet.Interactive.Telemetry.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Telemetry.Tests/Microsoft.DotNet.Interactive.Telemetry.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 portable-net45+win8+wp8+wpa81 $(NoWarn);8002 @@ -41,7 +41,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Telemetry/Microsoft.DotNet.Interactive.Telemetry.csproj b/src/Microsoft.DotNet.Interactive.Telemetry/Microsoft.DotNet.Interactive.Telemetry.csproj index e96100c8d2..615d0599f1 100644 --- a/src/Microsoft.DotNet.Interactive.Telemetry/Microsoft.DotNet.Interactive.Telemetry.csproj +++ b/src/Microsoft.DotNet.Interactive.Telemetry/Microsoft.DotNet.Interactive.Telemetry.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 latest diff --git a/src/Microsoft.DotNet.Interactive.Tests/Microsoft.DotNet.Interactive.Tests.csproj b/src/Microsoft.DotNet.Interactive.Tests/Microsoft.DotNet.Interactive.Tests.csproj index 0e445fcff8..eac3529f2d 100644 --- a/src/Microsoft.DotNet.Interactive.Tests/Microsoft.DotNet.Interactive.Tests.csproj +++ b/src/Microsoft.DotNet.Interactive.Tests/Microsoft.DotNet.Interactive.Tests.csproj @@ -1,7 +1,7 @@ - net6.0 + net7.0 latest portable-net45+win8+wp8+wpa81 $(NoWarn);8002 @@ -73,7 +73,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/Microsoft.DotNet.Interactive.Tests/Utility/KernelExtensionTestHelper.cs b/src/Microsoft.DotNet.Interactive.Tests/Utility/KernelExtensionTestHelper.cs index ac49acfad3..88de1feb20 100644 --- a/src/Microsoft.DotNet.Interactive.Tests/Utility/KernelExtensionTestHelper.cs +++ b/src/Microsoft.DotNet.Interactive.Tests/Utility/KernelExtensionTestHelper.cs @@ -132,7 +132,7 @@ public static async Task CreateExtensionNupkg( - net6.0 + net7.0 true {packageName} {packageVersion} @@ -163,7 +163,7 @@ public static async Task CreateExtensionNupkg( "), ("global.json", @"{ ""sdk"": { - ""version"": ""6.0.100"", + ""version"": ""7.0.100"", ""allowPrerelease"": true, ""rollForward"": ""latestMinor"" } @@ -271,7 +271,7 @@ private static async Task CreateExtensionProjectAndBuild( - net6.0 + net7.0 {extensionName} @@ -285,7 +285,7 @@ private static async Task CreateExtensionProjectAndBuild( "), ("global.json", @"{ ""sdk"": { - ""version"": ""6.0.100"", + ""version"": ""7.0.100"", ""allowPrerelease"": true, ""rollForward"": ""latestMinor"" } diff --git a/src/Microsoft.DotNet.Interactive.VSCode/Microsoft.DotNet.Interactive.VSCode.csproj b/src/Microsoft.DotNet.Interactive.VSCode/Microsoft.DotNet.Interactive.VSCode.csproj index 830658e7f3..2b50c5dfaf 100644 --- a/src/Microsoft.DotNet.Interactive.VSCode/Microsoft.DotNet.Interactive.VSCode.csproj +++ b/src/Microsoft.DotNet.Interactive.VSCode/Microsoft.DotNet.Interactive.VSCode.csproj @@ -1,7 +1,7 @@ - net6.0 + net7.0 latest diff --git a/src/Microsoft.DotNet.Interactive/KernelHost.cs b/src/Microsoft.DotNet.Interactive/KernelHost.cs index 1f5667c6c3..b5fa7cf48d 100644 --- a/src/Microsoft.DotNet.Interactive/KernelHost.cs +++ b/src/Microsoft.DotNet.Interactive/KernelHost.cs @@ -14,6 +14,7 @@ using Microsoft.DotNet.Interactive.Commands; using Microsoft.DotNet.Interactive.Connection; using Microsoft.DotNet.Interactive.Events; +using Pocket; namespace Microsoft.DotNet.Interactive { @@ -111,10 +112,16 @@ public async Task ConnectAsync() // this needs to be dispatched this way so that it does not block the current thread, which we see in certain bidirectional command scenarios (RequestInput sent by the SubmissionParser during magic command token interpolation) in stdio mode only (i.e. System.Console.In implementation details), and it has proven non-reproducible in tests. _eventLoop?.Schedule(async () => { - await _kernel.SendAsync(commandOrEvent.Command, _cancellationTokenSource.Token); + try + { + await _kernel.SendAsync(commandOrEvent.Command, _cancellationTokenSource.Token); + } + catch (Exception e) + { + Logger.Log.Error(e); + } }); } - }); await _defaultSender.SendAsync( diff --git a/src/dotnet-interactive-vscode-common/src/extension.ts b/src/dotnet-interactive-vscode-common/src/extension.ts index bb13f2519b..93b5233fa0 100644 --- a/src/dotnet-interactive-vscode-common/src/extension.ts +++ b/src/dotnet-interactive-vscode-common/src/extension.ts @@ -65,7 +65,7 @@ export async function activate(context: vscode.ExtensionContext) { const dotnetConfig = vscode.workspace.getConfiguration('dotnet-interactive'); const polyglotConfig = vscode.workspace.getConfiguration('polyglot-notebook'); - const minDotNetSdkVersion = dotnetConfig.get('minimumDotNetSdkVersion') || '6.0'; + const minDotNetSdkVersion = dotnetConfig.get('minimumDotNetSdkVersion') || '7.0'; const diagnosticsChannel = new OutputChannelAdapter(vscode.window.createOutputChannel('Polyglot Notebook : diagnostics')); const loggerChannel = new OutputChannelAdapter(vscode.window.createOutputChannel('Polyglot Notebook : logger')); DotNetPathManager.setOutputChannelAdapter(diagnosticsChannel); diff --git a/src/dotnet-interactive-vscode-insiders/package.json b/src/dotnet-interactive-vscode-insiders/package.json index 7115c3de24..5d1eabb34c 100644 --- a/src/dotnet-interactive-vscode-insiders/package.json +++ b/src/dotnet-interactive-vscode-insiders/package.json @@ -172,7 +172,7 @@ }, "dotnet-interactive.minimumDotNetSdkVersion": { "type": "string", - "default": "6.0", + "default": "7.0", "description": "The minimum required version of the .NET SDK." }, "dotnet-interactive.minimumInteractiveToolVersion": { diff --git a/src/dotnet-interactive-vscode/package.json b/src/dotnet-interactive-vscode/package.json index d285022a5c..af74b3fad3 100644 --- a/src/dotnet-interactive-vscode/package.json +++ b/src/dotnet-interactive-vscode/package.json @@ -172,7 +172,7 @@ }, "dotnet-interactive.minimumDotNetSdkVersion": { "type": "string", - "default": "6.0", + "default": "7.0", "description": "The minimum required version of the .NET SDK." }, "dotnet-interactive.minimumInteractiveToolVersion": { diff --git a/src/dotnet-interactive.Tests/HttpApiTests.cs b/src/dotnet-interactive.Tests/HttpApiTests.cs index 08c2098563..dd13810c9e 100644 --- a/src/dotnet-interactive.Tests/HttpApiTests.cs +++ b/src/dotnet-interactive.Tests/HttpApiTests.cs @@ -410,7 +410,7 @@ public async Task stdio_mode_returns_javascript_api_via_http() response.StatusCode.Should().Be(HttpStatusCode.OK); - response.Content.Headers.ContentType.MediaType.Should().Be("application/javascript"); + response.Content.Headers.ContentType.MediaType.Should().Be("text/javascript"); } private static int GetFreePort() diff --git a/src/dotnet-interactive.Tests/MagicCommandTests.about.cs b/src/dotnet-interactive.Tests/MagicCommandTests.about.cs index dff97ebe21..863851c64a 100644 --- a/src/dotnet-interactive.Tests/MagicCommandTests.about.cs +++ b/src/dotnet-interactive.Tests/MagicCommandTests.about.cs @@ -14,7 +14,7 @@ namespace Microsoft.DotNet.Interactive.App.Tests public class MagicCommandTests { [Collection("Do not parallelize")] - public class about + public class About { [Fact] public async Task it_shows_the_product_name_and_version_information() @@ -44,4 +44,4 @@ public async Task it_shows_the_product_name_and_version_information() } } } -} \ No newline at end of file +} diff --git a/src/dotnet-interactive.Tests/dotnet-interactive.Tests.csproj b/src/dotnet-interactive.Tests/dotnet-interactive.Tests.csproj index 4475a929a3..4436b981d6 100644 --- a/src/dotnet-interactive.Tests/dotnet-interactive.Tests.csproj +++ b/src/dotnet-interactive.Tests/dotnet-interactive.Tests.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 Microsoft.DotNet.Interactive.App.Tests $(NoWarn);8002 $(NoWarn);VSTHRD002 @@ -35,7 +35,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/src/dotnet-interactive/dotnet-interactive.csproj b/src/dotnet-interactive/dotnet-interactive.csproj index 9712a1b217..014be863e1 100644 --- a/src/dotnet-interactive/dotnet-interactive.csproj +++ b/src/dotnet-interactive/dotnet-interactive.csproj @@ -1,7 +1,7 @@  - net6.0 + net7.0 Microsoft.DotNet.Interactive.App Microsoft.DotNet.Interactive.App Latest diff --git a/src/interface-generator/interface-generator.csproj b/src/interface-generator/interface-generator.csproj index b7ed9250a8..ec3ed8bdaa 100644 --- a/src/interface-generator/interface-generator.csproj +++ b/src/interface-generator/interface-generator.csproj @@ -2,7 +2,7 @@ Exe - net6.0 + net7.0 Microsoft.DotNet.Interactive.InterfaceGen.App Microsoft.DotNet.Interactive.InterfaceGen.App