-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced ICU files for HybridGlobalization
#300
Reduced ICU files for HybridGlobalization
#300
Conversation
@ilonatommy - to clarify, the true property will control if we use the new .dat file correct ? So when that is set to false (default case), we will not see a size increase as it uses the only the old file ? |
Yes, the property controls weather we will load only the new, |
Changes LGTM. @akoeplinger @directhex please take a look. |
Are we not checking in a binary copy, to avoid the "random non-deterministic builds" issue? |
What do you mean by checking in binary copy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, looks good otherwise
The prebuilt file that we check into eng/prebuilts. I do see it in the PR, but maybe we should also let it be generated by @directhex's machine since it tends to produce the smallest binaries. |
@directhex, if you could help with that, then I will update the existing prebuilt with your version. |
First version of reduced ICU files for HybridGlobalization, Browser. Contributes to dotnet/runtime#79989.
HybridGlobalization is an optional function that can be switched on by the developer by adding
to the wasm project.
In that case, instead of loading default icu files, reduced icu files would be loaded to the app memory, correspondingly:
Because savings on some shards are marginal, sharding will not be enabled in Hybrid Globalization mode. From this reason, we are creating only one new file - for full ICU: icudt_wasm.dat.
cc @directhex, @akoeplinger - it will make the runtime pack increase.
The size of runtime pack will be increased by
icudt_wasm.dat
size: 812kB (202kB brotli copressed).We cannot stop shipping the original icu files and make HybridGlobalization the default and only option because HybridGlobalization does not provide 100% coverage with the current internalization behavior.
cc @SamMonoRT @tarekgh