Fix illegal XML doc in FSharp.Core #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Jul 30, 2020
KevinRansom
approved these changes
Jul 30, 2020
abelbraaksma
pushed a commit
to abelbraaksma/fsharp
that referenced
this pull request
Aug 9, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an illegal XML doc in FSharp.Core that can prevent FSharp.Core.xml loading into some tools
This may actually affect F# docs in Visual Studio, so is an important fix.
This is included in #9837, however we should accept this fix asap
We should also add a test that the FSHarp.Core.xml at least loads into a standard XML reader, I'll do that separately, I thought we had one but I can't find it. The code was added in this ed9b9b7 about 2 months ago so I guess we don't have an active test for validity, and this hasn't yet been released into the wild