Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xml doc for overloads #6246

Merged

Conversation

vasily-kirichenko
Copy link
Contributor

This fixes #6244

@vasily-kirichenko
Copy link
Contributor Author

File.WriteAllText:

MainDescription: File.WriteAllText(path: string, contents: string) : unit

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.File.WriteAllText(System.String,System.String)")

MainDescription: File.WriteAllText(path: string, contents: string, encoding: System.Text.Encoding) : unit

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.File.WriteAllText(System.String,System.String,System.Text.Encoding)")

MemoryStream ctor:

MainDescription: type MemoryStream =
  inherit Stream
  new : unit -> MemoryStream + 6 overloads
  member CanRead : bool
  member CanSeek : bool
  member CanWrite : bool
  member Capacity : int with get, set
  member CopyToAsync : destination:Stream * bufferSize:int * cancellationToken:CancellationToken -> Task
  member Flush : unit -> unit
  member FlushAsync : cancellationToken:CancellationToken -> Task
  member GetBuffer : unit -> byte[]
  member Length : int64
  ...

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "T:System.IO.MemoryStream")

MainDescription: MemoryStream() : MemoryStream

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.MemoryStream.#ctor")

MainDescription: MemoryStream(capacity: int) : MemoryStream

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.MemoryStream.#ctor(System.Int32)")

MainDescription: MemoryStream(buffer: byte []) : MemoryStream

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.MemoryStream.#ctor(System.Byte[])")

MainDescription: MemoryStream(buffer: byte [], writable: bool) : MemoryStream

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.MemoryStream.#ctor(System.Byte[],System.Boolean)")

MainDescription: MemoryStream(buffer: byte [], index: int, count: int) : MemoryStream

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.MemoryStream.#ctor(System.Byte[],System.Int32,System.Int32)")

MainDescription: MemoryStream(buffer: byte [], index: int, count: int, writable: bool) : MemoryStream

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.MemoryStream.#ctor(System.Byte[],System.Int32,System.Int32,System.Boolean)")

MainDescription: MemoryStream(buffer: byte [], index: int, count: int, writable: bool, publiclyVisible: bool) : MemoryStream

XmlDoc: XmlDocFileSignature
  ("C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.7.2\mscorlib.dll",
   "M:System.IO.MemoryStream.#ctor(System.Byte[],System.Int32,System.Int32,System.Boolean,System.Boolean)")

@KevinRansom KevinRansom changed the base branch from dev16.0 to master February 26, 2019 08:09
@KevinRansom KevinRansom changed the base branch from master to dev16.0 February 26, 2019 08:10
@KevinRansom KevinRansom merged commit 00e2161 into dotnet:dev16.0 Feb 26, 2019
@KevinRansom
Copy link
Member

@vasily-kirichenko, thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants