Add entity.DeclaringEntity to F# Compiler Service #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
|
This is great - more than I was hoping for! I can go from entity to parent entity or parent namespace, and get nested entities for namespaces. |
nosami
approved these changes
Mar 28, 2018
src/fsharp/tast.fs
Outdated
| @@ -4386,9 +4386,10 @@ and SlotParam = | |||
| member x.Type = let (TSlotParam(_,ty,_,_,_,_)) = x in ty | |||
|
|
|||
| /// A type for a module-or-namespace-fragment and the actual definition of the module-or-namespace-fragment | |||
| /// The first ModuleOrNamespaceType is the signature and is a binder. However the bindings are not used in the ModuleOrNamespaceExpr: it is only referenced from the 'outside' | |||
| // is for use by FCS only to report the "hidden" contents of the assembly prior to applying the signature. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements FCS feature request fsharp/fsharp-compiler-docs#830
This has been requested by @vasily-kirichenko (Visual F# Tools), @auduchinok (Jet Brains Rider) and @nosami (VS for Mac/F# Roslyn bridge)
Feature description
There are many situations where users of FCS symbols require a DeclaringEntity property on an FSharpEntity, e.g. for modules, or types, nested in other modules or types.
This implements this. The implementation requires plumbing through the "partially inferred assembly contents", which stem from CompileOps.fs.
PR Notes
I've renamed a number of things along the way as I needed to do it to understand/clarify/document some of this old code, e.g.
cenv-->SymbolEnvinSymbols.fsWithNoShortPrimaryAssemblyinil.fs/il.fsi. We never need this version of thingsTypeCheckOneInputEventuallyto pass the partial inferred assembly contents back directly, and thus reduce the number oftcstracking fields by oneSymbols.fs