Private val fix #28
Closed
Private val fix #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing added, I believe this fix is now ready. |
| let test () = | ||
| A.x <- 1 | ||
|
|
||
| module TestCompilerMessgeSet = |
There was a problem hiding this comment.
Please fix the typo: TestCompilerMessageSet
forki
referenced
this pull request
in forki/visualfsharp
Jan 21, 2015
fixes #27 resolves #28 commit bf3c9b3ff6151a09dd9319e5e54d21a0edd17c31 Merge: 5eb0657 7393d92 Author: latkin <[email protected]> Date: Mon Jan 19 16:57:58 2015 -0800 Merge branch 'private-val-fix' of https://github.com/dsyme/visualfsharp into dsyme-private-val-fix commit 7393d92 Author: Don Syme <[email protected]> Date: Sat Jan 17 11:50:54 2015 +0000 add tests for val sets commit 68555a3 Author: Don Syme <[email protected]> Date: Sat Jan 17 11:38:18 2015 +0000 adjust range reported in error commit bff938f Author: Don Syme <[email protected]> Date: Sat Jan 17 11:35:08 2015 +0000 fix compile commit d2f12e4 Author: Don Syme <[email protected]> Date: Sat Jan 17 11:33:41 2015 +0000 fix for private val set
dsyme
pushed a commit
to dsyme/fsharp
that referenced
this pull request
Jul 25, 2017
fix deadlocking test by safeguarding the wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #27. Testing needs to be added.