Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MacOS #18023

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Bump MacOS #18023

merged 3 commits into from
Nov 18, 2024

Conversation

psfinaki
Copy link
Member

MacOS-12 got deprecated, bump MacOS as per this.

@psfinaki psfinaki requested a review from a team as a code owner November 18, 2024 15:32
Copy link
Contributor

✅ No release notes required

Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It better be -latest, so there's no need to update it by hand.

@psfinaki
Copy link
Member Author

@vzarytovskii I thought about that, but:
a. Probably it's not a bad idea to have this fixed, to have control there from the security perspective - in the end, we have fixed version numbers in things like Versions.props
b. macos-15 is later that the latest 🤷 latest is macos-14

I mean, not a strong position, just sharing my considerations - can change.

@vzarytovskii
Copy link
Member

@vzarytovskii I thought about that, but: a. Probably it's not a bad idea to have this fixed, to have control there from the security perspective - in the end, we have fixed version numbers in things like Versions.props b. macos-15 is later that the latest 🤷 latest is macos-14

I mean, not a strong position, just sharing my considerations - can change.

latest usually means "latest supported", which is exactly what you would want, it's bumped automatically, so engineering systems can take care of it for you.

psfinaki and others added 2 commits November 18, 2024 18:08
Co-authored-by: Vlad Zarytovskii <[email protected]>
Co-authored-by: Vlad Zarytovskii <[email protected]>
@psfinaki
Copy link
Member Author

Alright then, there you go :)

@vzarytovskii vzarytovskii merged commit fa60e8c into dotnet:main Nov 18, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants