Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DefaultAugmentationAttribute #17502

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Update DefaultAugmentationAttribute #17502

merged 5 commits into from
Aug 7, 2024

Conversation

KevinRansom
Copy link
Member

Fixes #17499

DefaultAugmentationAttribute only targeted class, also must target struct.

@KevinRansom KevinRansom requested a review from a team as a code owner August 7, 2024 00:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/9.0.100.md

@psfinaki psfinaki enabled auto-merge (squash) August 7, 2024 16:41
@psfinaki psfinaki merged commit 15b5a6c into dotnet:main Aug 7, 2024
30 checks passed
This was referenced Aug 13, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarfgp edgarfgp edgarfgp approved these changes

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Struct UnionCase doesn't seem to be a valid target for the DefaultAugmentationAttribute
4 participants
@KevinRansom @vzarytovskii @psfinaki @edgarfgp