-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function
implicit conversion the same way as fun x
#17487
function
implicit conversion the same way as fun x
#17487
Conversation
❗ Release notes required
|
0b1e680
to
725e8cb
Compare
ec5e55b
to
bfcd2d8
Compare
Co-authored-by: Brian Rourke Boll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you Edgar!
/azp run |
...BasicGrammarElements/MemberDefinitions/OverloadingMembers/OverloadResolutionUsingFunction.fs
Outdated
Show resolved
Hide resolved
This reverts commit 358d296.
All branches
Two comments on the approach used in 581be73:
|
Can we measure the diff between old and new allocation-wise in long-running scenarios? One-off compilation won't be a concern, continuous allocations in tooling might be. Service currently is not exactly known to be memory-friendly, probably don't want make it worse (I doubt it will be with the change, since nothing will likely escape gen0, but just want a sanity check). |
|
Use struct tuples
@vzarytovskii Does Brian's changes cover your expectations ? |
Description
Fixes #7401
Checklist