Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ReflectionFree if PublishAot is set, and delay that decision until after the project file has been loaded. #17362

Conversation

baronfel
Copy link
Member

@baronfel baronfel commented Jun 27, 2024

Description

This PR delays the default of ReflectionFree until the .target files, so the user project's PublishAot value can influence the default chosen for ReflectionFree.

Since AOT apps require ReflectionFree to be useful, this seems like a helpful default.

Fixes #17361

Checklist

  • Test cases added

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@baronfel baronfel linked an issue Jun 27, 2024 that may be closed by this pull request
Copy link
Contributor

✅ No release notes required

@baronfel baronfel closed this Jun 28, 2024
@baronfel
Copy link
Member Author

Closing per note in #17361 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PublishTrimmed or PublishAot should imply ReflectionFree
1 participant