Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter diagnostics for errors. #16622

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Filter diagnostics for errors. #16622

merged 2 commits into from
Jan 31, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 31, 2024

Description

My project had a lot of warnings and info in the diagnostics.
I believe we can safely filter these out.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner January 31, 2024 11:07
@nojaf nojaf requested a review from 0101 January 31, 2024 11:07
@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@nojaf
Copy link
Contributor Author

nojaf commented Jan 31, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 16622 in repo dotnet/fsharp

@nojaf
Copy link
Contributor Author

nojaf commented Jan 31, 2024

Some CompilerService.AsyncMemoize tests are failing. They run fine locally, pretty sure this is unrelated.

@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@0101
Copy link
Contributor

0101 commented Jan 31, 2024

Some CompilerService.AsyncMemoize tests are failing. They run fine locally, pretty sure this is unrelated.

Yeah they are flaky. The fix for that is here: #16612

@psfinaki psfinaki enabled auto-merge (squash) January 31, 2024 15:25
@psfinaki psfinaki merged commit af4e7a1 into dotnet:main Jan 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@0101 0101 0101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @psfinaki @0101