Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexer property should not allowed to have mismatched value type #16023

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Indexer property should not allowed to have mismatched value type #16023

merged 3 commits into from
Nov 6, 2023

Conversation

edgarfgp
Copy link
Contributor

Fixes #9232

This was done as part of an AmplifyingFSharp session https://amplifying-fsharp.github.io/sessions/2023/09/22/

@edgarfgp edgarfgp mentioned this pull request Sep 26, 2023
Closed
@edgarfgp edgarfgp force-pushed the indexed-properties-setter-warning branch from c0b433c to 19cec48 Compare September 30, 2023 11:09
@edgarfgp edgarfgp force-pushed the indexed-properties-setter-warning branch from 19cec48 to 96d4b78 Compare November 5, 2023 13:34
@edgarfgp edgarfgp marked this pull request as ready for review November 5, 2023 17:50
@edgarfgp edgarfgp requested a review from a team as a code owner November 5, 2023 17:50
T-Gro
T-Gro approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be technically breaking (wrong code && warning as error), but per Don's comment here it can be considered as bugfix:

#9232 (comment)

psfinaki
psfinaki approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psfinaki psfinaki merged commit c2031c2 into dotnet:main Nov 6, 2023
24 checks passed
@edgarfgp edgarfgp mentioned this pull request Nov 6, 2023
Closed
@allisonchou allisonchou mentioned this pull request Nov 13, 2023
Closed
@edgarfgp edgarfgp mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indexer/propery is allowed to have mismatched value type
3 participants
@edgarfgp @psfinaki @T-Gro