From 307bd35327ac4f3094918da733bc4207e332931e Mon Sep 17 00:00:00 2001
From: Ross Kuehl <94796738+rosskuehl@users.noreply.github.com>
Date: Wed, 28 Dec 2022 15:31:07 -0500
Subject: [PATCH 1/2] fix isRecursive binding in ServiceParseTreeWalk.fs

---
 src/Compiler/Service/ServiceParseTreeWalk.fs |  2 +-
 tests/service/TreeVisitorTests.fs            | 18 +++++++++++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/Compiler/Service/ServiceParseTreeWalk.fs b/src/Compiler/Service/ServiceParseTreeWalk.fs
index 2a335d274e9..8415ec401fd 100644
--- a/src/Compiler/Service/ServiceParseTreeWalk.fs
+++ b/src/Compiler/Service/ServiceParseTreeWalk.fs
@@ -594,7 +594,7 @@ module SyntaxTraversal =
 
                 | SynExpr.TypeApp (synExpr, _, _synTypeList, _commas, _, _, _range) -> traverseSynExpr synExpr
 
-                | SynExpr.LetOrUse (_, isRecursive, synBindingList, synExpr, range, _) ->
+                | SynExpr.LetOrUse (isRecursive, _, synBindingList, synExpr, range, _) ->
                     match visitor.VisitLetOrUse(path, isRecursive, traverseSynBinding path, synBindingList, range) with
                     | None ->
                         [
diff --git a/tests/service/TreeVisitorTests.fs b/tests/service/TreeVisitorTests.fs
index 9bcfa47796a..caf952b6de3 100644
--- a/tests/service/TreeVisitorTests.fs
+++ b/tests/service/TreeVisitorTests.fs
@@ -58,4 +58,20 @@ let ``Visit enum definition test`` () =
 
     match SyntaxTraversal.Traverse(pos0, parseTree, visitor) with
     | Some [ SynEnumCase (_, SynIdent(id1,_), _, _, _, _, _); SynEnumCase (_, SynIdent(id2,_), _, _, _, _, _) ] when id1.idText = "A" && id2.idText = "B" -> ()
-    | _ -> failwith "Did not visit enum definition"
\ No newline at end of file
+    | _ -> failwith "Did not visit enum definition"
+
+[<Test>]
+let ``Visit recursive let binding`` () =
+    let visitor =
+        { new SyntaxVisitorBase<_>() with
+            member x.VisitExpr(_, _, defaultTraverse, expr) = defaultTraverse expr
+            member x.VisitLetOrUse(_, isRecursive, _, bindings, _) =
+                if not isRecursive then failwith $"{nameof isRecursive} should be true"
+                Some bindings }
+
+    let source = "let rec fib n = if n < 2 then n else fib (n - 1) + fib (n - 2) in fib 10"
+    let parseTree = parseSourceCode("C:\\test.fs", source)
+
+    match SyntaxTraversal.Traverse(pos0, parseTree, visitor) with
+    | Some [ SynBinding (_, _, _, _, _, _, SynValData(_, SynValInfo([[ SynArgInfo(_, _, Some id) ]], _), _), _, _, _, _, _, _) ] when id.idText = "n" -> ()
+    | _ -> failwith "Did not visit recursive let binding"
\ No newline at end of file

From a615f58b8547dbcef97569a047548eca6f60dcea Mon Sep 17 00:00:00 2001
From: Ross Kuehl <94796738+rosskuehl@users.noreply.github.com>
Date: Thu, 29 Dec 2022 10:16:00 -0500
Subject: [PATCH 2/2] use named access on ident pattern match

---
 tests/service/TreeVisitorTests.fs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/service/TreeVisitorTests.fs b/tests/service/TreeVisitorTests.fs
index caf952b6de3..58bda80d487 100644
--- a/tests/service/TreeVisitorTests.fs
+++ b/tests/service/TreeVisitorTests.fs
@@ -73,5 +73,5 @@ let ``Visit recursive let binding`` () =
     let parseTree = parseSourceCode("C:\\test.fs", source)
 
     match SyntaxTraversal.Traverse(pos0, parseTree, visitor) with
-    | Some [ SynBinding (_, _, _, _, _, _, SynValData(_, SynValInfo([[ SynArgInfo(_, _, Some id) ]], _), _), _, _, _, _, _, _) ] when id.idText = "n" -> ()
+    | Some [ SynBinding(valData = SynValData(valInfo = SynValInfo(curriedArgInfos = [ [ SynArgInfo(ident = Some id) ] ]))) ] when id.idText = "n" -> ()
     | _ -> failwith "Did not visit recursive let binding"
\ No newline at end of file