Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go figure ... You need to waitforexit() after waitforexit(n) with redirected output #10773

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Go figure ... You need to waitforexit() after waitforexit(n) with redirected output #10773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fsharp/FSharp.DependencyManager.Nuget/FSharp.DependencyManager.Utilities.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ module internal Utilities =
// Timed out resolving throw a diagnostic.
raise (new TimeoutException(SR.timedoutResolvingPackages(psi.FileName, psi.Arguments)))
else
()
p.WaitForExit()

#if DEBUG
File.WriteAllLines(Path.Combine(workingDir, "StandardOutput.txt"), outputList)
Expand Down
2 changes: 1 addition & 1 deletion tests/FSharp.Test.Utilities/TestFramework.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module Commands =
// Timed out resolving throw a diagnostic.
raise (new TimeoutException(sprintf "Timeout executing command '%s' '%s'" (psi.FileName) (psi.Arguments)))
else
()
p.WaitForExit()
#if DEBUG
File.WriteAllLines(Path.Combine(workingDir, "StandardOutput.txt"), outputList)
File.WriteAllLines(Path.Combine(workingDir, "StandardError.txt"), errorsList)
Expand Down