Provide a mechanism for pinning type signatures formats during printing #10744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
reviewed
Dec 16, 2020
| @@ -2796,7 +2802,8 @@ type DisplayEnv = | |||
| printVerboseSignatures = false | |||
| g = tcGlobals | |||
| contextAccessibility = taccessPublic | |||
| generatedValueLayout = (fun _ -> None) } | |||
| generatedValueLayout = (fun _ -> None) | |||
| genericParameterStyle = GenericParameterStyle.Implicit } | |||
There was a problem hiding this comment.
Is this the correct default?
There was a problem hiding this comment.
This preserves the behavior currently, which is to print based on the state of the flag on the TyCon.
I could see a future FCS release where we say 'nah let's just go for Prefix by default' and we'd change it here, though.
Co-authored-by: Phillip Carter <[email protected]>
Co-authored-by: Phillip Carter <[email protected]>
|
I would very much be surprised if any logic tests failed, as I intended to make this feature opt-in entirely. Surface area tests I do expect to fail. |
cartermp
approved these changes
Dec 17, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…ng (dotnet#10744) Co-authored-by: Phillip Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FSAC we have some pretty convoluted logic for undoing the compiler's default printing of generic type parameters for types that use the suffix form (ie
int list).We'd love a way to explicit ask NicePrint to render the type signature in a given way, either prefix or suffix, regardless of the derived flag on the type itself.
To that end, this PR: