Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy XmlDocuments to output directory #10579

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Copy XmlDocuments to output directory #10579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f613d6
Copy XmlDocuments to output directory
KevinRansom Dec 1, 2020
f70f9f7
feedback
KevinRansom Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/fsharp/FSharp.Core/FSharp.Core.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@
<dependencies>
<group targetFramework=".NETStandard2.0" />
</dependencies>
<contentFiles> <!-- Deploy doc comments as Content -->
<files include="**/*" buildAction="None" copyToOutput="true" flatten="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this pick up anything other than the XML file? How do we know? I'm concerned that this will pull in a bunch of garbage.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettfo, it only picks up contentFiles. I think I can specify the exact filename though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There it's 'splicit now.

</contentFiles>
</metadata>
<files>
$CommonFileElements$

<file src="FSharp.Core\$Configuration$\netstandard2.0\FSharp.Core.dll" target="lib\netstandard2.0" />
<file src="FSharp.Core\$Configuration$\netstandard2.0\FSharp.Core.xml" target="lib\netstandard2.0" />
<file src="FSharp.Core\$Configuration$\netstandard2.0\FSharp.Core.dll" target="lib\netstandard2.0" />
<file src="FSharp.Core\$Configuration$\netstandard2.0\FSharp.Core.xml" target="lib\netstandard2.0" />
<file src="FSharp.Core\$Configuration$\netstandard2.0\FSharp.Core.xml" target="contentFiles/any/netstandard2.0" />

<!-- resources -->
<file src="FSharp.Core\$Configuration$\netstandard2.0\**\FSharp.Core.resources.dll" target="lib\netstandard2.0" />
Expand Down