Increase package version #10422
Merged
Increase package version #10422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should be made directly in |
|
@brettfo , this is preparing for when we service. And I fully intend to cherry pick it into master. |
|
We have auto-merges setup from 16.8 to main so you shouldn't have to cherry-pick anything. |
|
@brettfo ahh nice ... I forgot that. Thx |
auduchinok
reviewed
Nov 12, 2020
| @@ -290,7 +290,7 @@ tInput.Length | |||
| [<Fact>] | |||
| member __.``System.Device.Gpio - Ensure we reference the runtime version of the assembly``() = | |||
| let code = """ | |||
| #r "nuget:System.Device.Gpio" | |||
| #r "nuget:System.Device.Gpio, 1.0.0" | |||
There was a problem hiding this comment.
Could this be fixed in main instead?
|
It's fixed in main. This is release/dev16.8 which is a servicing branch, and so doesn't get automerges. |
brettfo
approved these changes
Nov 12, 2020
brettfo
added a commit
that referenced
this pull request
Nov 16, 2020
Back off part of #10422 because version numbers are hard and if we do need to service this, we'll have to pull in more substantial changes.
brettfo
added a commit
that referenced
this pull request
Nov 16, 2020
Back off part of #10422 because version numbers are hard and if we do need to service this, we'll have to pull in more substantial changes.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* :Increase package version * Update gpio test
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Back off part of dotnet#10422 because version numbers are hard and if we do need to service this, we'll have to pull in more substantial changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have shipped FSharp.Core and FCS nuget packages. Well almost ....
Update fcs build version to:
