Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary nonsense attributes can be added to type extensions #7394

Closed
cartermp opened this issue Aug 14, 2019 · 3 comments · Fixed by #7481
Closed

Arbitrary nonsense attributes can be added to type extensions #7394

cartermp opened this issue Aug 14, 2019 · 3 comments · Fixed by #7481
Labels
Bug
Milestone
16.5

Comments

@cartermp
Copy link
Contributor

Consider the following:

open System

[<Hello.my.name.is.Don.Syme>]
type String with
    member this.Doot() = this.Length

image

This should emit an error.
@dsyme
Copy link
Contributor

dsyme commented Aug 16, 2019

Yup

@cartermp cartermp added this to the Backlog milestone Aug 16, 2019
@nelson-wu nelson-wu mentioned this issue Sep 3, 2019
Merged
@KevinRansom
Copy link
Member

@cartermp, @dsyme.

Theoretically this is a breaking change. Given that the attributes are garbage, we should be prepared to tell developers to fix their code. If they see the error.

Kevin

@cartermp
Copy link
Contributor Author

cartermp commented Sep 4, 2019

Agreed

@cartermp cartermp modified the milestones: Backlog, 16.5 Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
16.5
Development

Successfully merging a pull request may close this issue.

Disallow attributes on type extensions nelson-wu/fsharp
3 participants
@KevinRansom @cartermp @dsyme