Rename FSharp.Editor --> VisualFSharp.Editor etc.

[dsyme]

I suggest that at some opportune moment we rename all the components of the Visual F# IDE Tools as follows:

FSharp.Editor --> VisualFSharp.Editor
FSharp.LanguageService --> VisualFSharp.LanguageService

and so on. Perhaps adding the "Microsoft" prefix, I don't mind.

This will make it much clearer what is "core F#" and what is the Visual F# IDE tools. (From a broad F# naming perspective assemblies like FSHarp.Editor are clearly misnamed)

[vasily-kirichenko]

Roslyn's IVT should be updated accordingly.

[dsyme]

@vasily-kirichenko Good point :)

[KevinRansom]

@dsyme I would rather not have to coordinate a change in IVT with roslyn, as well as muck with deployment and whatever else is necessary, stuff always breaks and there is always a bug tail. Can we just leave well enough alone ... please?

[smoothdeveloper]

@KevinRansom / @dsyme what is the problem for asking the Roslyn team to add the IVT with the new names without removing old ones?

This way we can wait for next round before renaming our projects / assemblies.

We shouldn't close issues which are geared toward making this repository more coherent, even if we can't act on those right now.

[KevinRansom]

So is this a high value change ? does it change/add/remove any functionality? does it simplify deployment or tooling? if the answer is no ... why risk the bugs?

Stuff breaks here all of the time because we rely on internals why would we do something that would for a while at least make things more likely to break?

[dsyme]

I think there is high value in this change - both with regard to eventual repo separation (compiler v. IDE tools) and making it easier to put the right things in the right place.

But there's absolutely no rush to do it. The IVT is a clinching issue for me which makes this hard. Let's aspire to do this eventually, once the IVT disappears, or do it to FSharp.Editor last.

Examples where better naming would have helped:

• I incorrectly placed a whole bunch of FSharp.Compiler.Service unit tests into VisualFSharp.UnitTests (which was then called FSharp.Unittests or the like). This was wrong - the FCS unittests should have merged with FSharp.Compiler.Unittests. I now have to go and correct that in order to get the tests to run on Mono. If the naming had been right, I wouldn't have made this mistake.

• There is a logical simplicity to "If it begins with FSharp..., it runs on Mono and .NET Core. If it begins with VisualFSharp...., it is windows only". Without clear naming, I think a lot of other contributors get likewise confused in a niggling kind of way about the correct separation of F# and the Visual F'# IDE Tools, because our naming is messy.

[KevinRansom]

Yes please ...

[cartermp]

@dsyme Should this be tracked in #2854 instead?

[cartermp]

Closing to track in #2854 instead