Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PEverify tests to use ilverify #13854

Closed
vzarytovskii opened this issue Sep 7, 2022 · 1 comment
Closed

Move PEverify tests to use ilverify #13854

vzarytovskii opened this issue Sep 7, 2022 · 1 comment
Labels
Area-Testing Engineering
Milestone
Backlog

Comments

@vzarytovskii
Copy link
Member

PEverify fork is quite old and not compatible with coreclr (and has problems building with .net7p7+), we need to move those tests to use ilverify.
@vzarytovskii vzarytovskii added this to the Backlog milestone Sep 7, 2022
@vzarytovskii vzarytovskii self-assigned this Sep 7, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Sep 7, 2022
@vzarytovskii vzarytovskii mentioned this issue Oct 3, 2022
Open
@0101 0101 removed the Needs-Triage label Feb 27, 2023
@vzarytovskii vzarytovskii removed their assignment Mar 20, 2023
@vzarytovskii
Copy link
Member Author

I don't think we want to specifically move those, since they were part of F#QA tests, and no part of new suite. Will reopen/create new one if we feel the need in those tests. Now IL baselines + running tests should be enough to test loading.

@vzarytovskii vzarytovskii closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Testing Engineering
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@0101 @vzarytovskii