Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrentCulture is not preserved between submissions of desktop fsi #13701

Closed
KevinRansom opened this issue Aug 16, 2022 · 2 comments
Closed

CurrentCulture is not preserved between submissions of desktop fsi #13701

KevinRansom opened this issue Aug 16, 2022 · 2 comments
Assignees
Labels
Area-FSI Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. Resolution-By Design
Milestone

Comments

@KevinRansom
Copy link
Member

KevinRansom commented Aug 16, 2022

dotnet fsi appears to, but that may just be an accident.

Repro:
Start fsi
paste in this script

open System
open System.Globalization

System.Globalization.CultureInfo.CurrentCulture <- System.Globalization.CultureInfo.GetCultureInfo("nl-NL")

System.Console.WriteLine(System.Globalization.CultureInfo.CurrentCulture);;
System.Console.WriteLine(System.Globalization.CultureInfo.CurrentCulture);;

observe that currentculture is different in both submissions.
image

dotnet fsi being right
image

@dsyme
Copy link
Contributor

dsyme commented Sep 23, 2022

@KevinRansom This only happens when "--gui" event loop support is enabled, as in .NET Framework fsi but not in dotnet fsi. I'm not sure it should be fixed.

I guess we should consider whether we want some kind of event loop support for dotnet fsi. We haven't exactly documented this difference.

@KevinRansom
Copy link
Member Author

There is no need to fix this. It is how it has always worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-FSI Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. Resolution-By Design
Projects
Archived in project
Development

No branches or pull requests

3 participants