Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the signature tests from cambridge suite to CompilerComent tests #13367

Closed
KevinRansom opened this issue Jun 23, 2022 · 0 comments · Fixed by #14317
Closed

Move the signature tests from cambridge suite to CompilerComent tests #13367

KevinRansom opened this issue Jun 23, 2022 · 0 comments · Fixed by #14317
Assignees
@T-Gro
Labels
Engineering Needs-Triage
Milestone
December-2022

Comments

@KevinRansom
Copy link
Member

KevinRansom commented Jun 23, 2022 •
edited
Loading

While reviewing a recent PR that added a new signature test to the cambridge suite I noticed that:

fsharp/tests/fsharp/tests.fs

Line 3340 in f9c5b42

module GeneratedSignatureTests =

  1. The small suite of signature tests run on the desktop clr only. They run on the desktop because they invoke the compiler with the results of building the sig file
  2. They would work fine in one of the better test frameworks we have.

We should move these tests away from the crazy place that is the cambridge suite :-)
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Jul 7, 2022
@vzarytovskii vzarytovskii added this to the Backlog milestone Jul 7, 2022
@vzarytovskii vzarytovskii mentioned this issue Oct 3, 2022
Open
@T-Gro T-Gro self-assigned this Nov 2, 2022
@T-Gro T-Gro modified the milestones: Backlog, November-2022 Nov 2, 2022
@T-Gro T-Gro linked a pull request Dec 1, 2022 that will close this issue
Move signature tests from cambridge suite to component tests #14317
Merged
@T-Gro T-Gro closed this as completed Dec 1, 2022
Repository owner moved this from Not Planned to Done in F# Compiler and Tooling Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T-Gro T-Gro

Labels
Engineering Needs-Triage
Projects
F# Compiler and Tooling
Archived in project
Milestone
December-2022
3 participants
@vzarytovskii @KevinRansom @T-Gro