Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find all references property failures #10811

Closed
charlesroddie opened this issue Dec 26, 2020 · 0 comments · Fixed by #10836
Closed

Find all references property failures #10811

charlesroddie opened this issue Dec 26, 2020 · 0 comments · Fixed by #10836
Labels
Area-FCS Regression
Milestone
16.9

Comments

@charlesroddie
Copy link
Contributor

charlesroddie commented Dec 26, 2020 •
edited
Loading

Generally we find that "find all references" works at most half of the time and I was able to reproduce this in the simplest possible examples of property getters and setters:

Getters

image

Setters

Find all references on a property with a setter fails to detect usage of the setter and instead detects the definition:

image
@charlesroddie charlesroddie changed the title Find all references failures Find all references property failures Dec 26, 2020
@cartermp cartermp added this to the Backlog milestone Dec 26, 2020
@TIHan TIHan mentioned this issue Jan 5, 2021
Merged
@cartermp cartermp linked a pull request Jan 5, 2021 that will close this issue
Fixed find all references on properties #10836
Merged
@cartermp cartermp modified the milestones: Backlog, 16.9 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-FCS Regression
Projects
None yet
Milestone
16.9
Development

Successfully merging a pull request may close this issue.

Fixed find all references on properties TIHan/visualfsharp
2 participants
@cartermp @charlesroddie