-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working implementation of precompiled queries #29949
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Dec 30, 2022
|
||
outputDir = Path.GetFullPath(Path.Combine(_projectDir, outputDir ?? "")); | ||
|
||
// TODO: Need the project csproj. For now hacking an assumption that the csproj is the same as the assembly name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @bricelam, can we get the csproj here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you'll need to flow it (MSBuildProjectFile
) in from dotnet-ef the same way we do projectDir
* Fix NewArray * Implement expression list lifting properly (New, Call, Invocation, NewArray) * General cleanup
roji
force-pushed
the
PrecompiledQueries
branch
from
January 4, 2023 23:38
9aba51f
to
2c4d325
Compare
roji
force-pushed
the
PrecompiledQueries
branch
from
January 5, 2023 13:09
2c4d325
to
4d47e5f
Compare
roji
force-pushed
the
PrecompiledQueries
branch
from
January 5, 2023 19:22
898b1ec
to
13bf019
Compare
roji
force-pushed
the
PrecompiledQueries
branch
from
January 6, 2023 17:26
fd3008a
to
333fdec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first "semi-complete" working implementation of precompiled queries (#25009), for creating a feature branch. We can use this PR for first discussions.
To test this:
<ProjectReference>
, and rundotnet ef dbcontext optimize
(I've replaced that to do precompiled querying, until we decide on the exact CLI switch (also to make it easier to test without needing a modified dotnet-ef tool)).Triggering precompilation from your console app
This is by no means complete - I have a list of stuff that still needs to be done (split query, ExecuteUpdate/Delete, SQL queries, possibly some expression tree edge cases...).
To track issues you come across, I suggest posting them as a todo list in #25009 - no need for lots of different issues at this point).