Bring back SQLite (Resolves #1953) #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| Create(); | ||
|
|
||
| return Task.FromResult(0); | ||
| } |
There was a problem hiding this comment.
Are we okay with a blocking default implementation of these async methods? /cc @divega
There was a problem hiding this comment.
Seems consistent with the default implementation of the async methods in relational, i.e. ADO.NET. I would add cancellationToken.ThrowIfCancellationRequested() on each of them though.
There was a problem hiding this comment.
Will throw when cancelled.
|
|
This was referenced Apr 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty crippled at the moment. Things like
.Count()don't work because the provider returns a boxedlongthat we try to cast to anint. There also seems to be something wrong with theLIKEoperator (possibly an encoding issue). Migrations isn't implemented (but.EnsureCreated()should more-or-less work). ...just to name a few.