Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Review: Scaffolding changes #8739

Closed
bricelam opened this issue Jun 5, 2017 · 6 comments
Closed

API Review: Scaffolding changes #8739

bricelam opened this issue Jun 5, 2017 · 6 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone

Comments

@bricelam
Copy link
Contributor

bricelam commented Jun 5, 2017

  • Rename AnnotationRendererBase to AnnotationCodeGenerator
  • Rename IAnnotationRenderer to IAnnotationCodeGenerator
  • Remove the following
    • RelationalForeignKeyAnnotations.GetDefaultForeignKeyName
    • RelationalIndexAnnotations.GetDefaultIndexName
  • Revert making RelationalKeyAnnotations.GetDefaultName public
  • Move the following to Internal namespace or remove them if they'll show up on app code
    • ScaffoldingEntityTypeAnnotations
    • ScaffoldingMetadataExtensions
    • ScaffoldingModelAnnotations
    • ScaffoldingPropertyAnnotations
  • Rename IScaffoldingHelper to IScaffoldingCodeGenerator
  • Rename IScaffoldingHelper.GetProviderOptionsBuilder to GenerateUseProvider
  • Move IScaffoldingHelper.GetTypeScaffoldingInfo to a different interface or investigate improving its design
  • Investigate whether ScaffoldingTypeMapper can move to Internal namespace
@bricelam bricelam added this to the 2.0.0-preview2 milestone Jun 5, 2017
@bricelam bricelam self-assigned this Jun 5, 2017
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 6, 2017
@weitzhandler
Copy link
Contributor

I'm waiting for this to come live.

I'd really love to see an end-to-end entity graph management for disconnected clients.
Something like Breeze# or Trackable-Entities.

I believe with scaffolding this will become a step closer.

@ajcvickers
Copy link
Contributor

@weitzhandler What are you waiting for here? These are just renames, and they were already pushed and released in preview2.

@weitzhandler
Copy link
Contributor

weitzhandler commented Jul 12, 2017

@ajcvickers
Sorry then.
I'm not really using EF7 yet, just playing around (it's missing Complex-Types and TPT - key features mandatory to us).
When I shall start using it (once those 2 aspects are addressed), I'm noting to myself a point where gathering metadata can be made easier.

Really I wish the EF team would implement or adopt an in-house solution for disconnected entity graph manipulation and caching for clients.
Specific use case would be to support UWP and Xamarin.Forms apps, which is currently a nightmare involving a lot of repetitive work.

@bricelam
Copy link
Contributor Author

Have you seen Azure Mobile Apps? Not sure if it's quite what you're looking for...

@weitzhandler
Copy link
Contributor

weitzhandler commented Jul 12, 2017

Thanks for the reply @bricelam
I've fiddled with it a little bit, and from what I understood, it's good if you build your project from scratch based on it, additionally I haven't found support for committing complete graph change, which is the issue i was concerned with.
I wish I'm wrong, can you mention here someone from the Azure team?

@weitzhandler
Copy link
Contributor

weitzhandler commented Aug 15, 2017

Besides Azure tables doesn't give an answer to dealing with complex entity graphs, like TrackableEntities or Breeze does. Please see my comments on #5536.

@ajcvickers ajcvickers modified the milestones: 2.0.0-preview2, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Development

No branches or pull requests

3 participants