ValueGeneratedOnAdd index is not reset across InMemoryDatabase instances

[aphex-]

I wrote some tests using Xunit. Every [Fact] method creates a new DBContext to test.

    var services = new ServiceCollection();
    services.AddEntityFrameworkInMemoryDatabase()
        .AddDbContext<ApplicationContext>(
	    options => options.UseInMemoryDatabase(Guid.NewGuid().ToString()));

An User has the property ID

     protected override void OnModelCreating(ModelBuilder modelBuilder)
     {
          // ...
          modelBuilder.Entity<User>().HasKey(e => e.Id)
          modelBuilder.Entity<User>().Property(f => f.Id).ValueGeneratedOnAdd();
          // ...
     }

As test data I add two users without assigning their ids:

     conext.Users.Add(new User {Name = "Peter"});
     conext.Users.Add(new User {Name = "Paul"});

My DBContext sometimes contains: Peter (id:3) and Paul (id:4) if I run the tests. I am not sure if this only occurs on tests that are using a [Theory].

(If I explicitly set the ids while adding the users it works as expected. This workaround solves the issue in my case.)

Further technical details

EF Core version: "Microsoft.NETCore.App": { "version": "1.1.0", "type": "platform" },
Database Provider: InMemoryDatabase
Operating system: macOS Sierra 10.12.1
IDE: JetBrains Rider 1.0 EAP

[ErikEJ]

InMemory is not a relational provider - it is unfortunate the the extension method is named AddEntityFrameworkInMemoryDatabase rather than AddEntityFrameworkInMemoryProvider or similar

[ajcvickers]

Dupe of #6872