Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All PRs were merged on green, and yet the build was still broken #34139

Closed
ajcvickers opened this issue Jul 2, 2024 · 1 comment · Fixed by #34111
Closed

All PRs were merged on green, and yet the build was still broken #34139

ajcvickers opened this issue Jul 2, 2024 · 1 comment · Fixed by #34111
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution type-bug
Milestone
9.0.0

Comments

@ajcvickers
Copy link
Member

Figure out why the CI for PRs didn't catch this.

See also #34137

image
@ranma42
Copy link
Contributor

ranma42 commented Jul 2, 2024

The CI is not asserting that the baselines match for the compiled model tests. #34111 fixes this.

@ranma42 ranma42 mentioned this issue Jul 2, 2024
Merged
@AndriySvyryd AndriySvyryd added area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution labels Jul 2, 2024
@AndriySvyryd AndriySvyryd added this to the 9.0.0 milestone Jul 2, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview7 Jul 8, 2024
@roji roji modified the milestones: 9.0.0-preview7, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution type-bug
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Enable testing of compiled models in CI ranma42/efcore
4 participants
@ajcvickers @ranma42 @roji @AndriySvyryd