Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optionally) expose QueryCompilationContext to method/member translators #31485

Open
roji opened this issue Aug 16, 2023 · 0 comments
Open

(Optionally) expose QueryCompilationContext to method/member translators #31485

roji opened this issue Aug 16, 2023 · 0 comments

Comments

@roji
Copy link
Member

roji commented Aug 16, 2023

Our translators currently aren't passed the query compilation context, and so they lack access to various settings and advanced query compilation features. For example, #31482 added support for escaping wildcard characters for LIKE patterns when the pattern is a parameter; since that requires access to RegisterRuntimeParameter, the translation code had to be moved to the provider's SqlTranslatingExpressionVisitor. Once translators can access the QCC, that code can be moved back to the translator where it belongs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants