Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up SelectExpression construction #31379

Closed
roji opened this issue Jul 31, 2023 · 1 comment
Closed

Open up SelectExpression construction #31379

roji opened this issue Jul 31, 2023 · 1 comment
Assignees
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@roji
Copy link
Member

roji commented Jul 31, 2023

To support the primitive collection and JSON querying work in 8.0, we needed to add some very scenario-specific constructors to SelectExpressions, e.g. accepting an arbitrary ordering column from the outside for OPENJSON/json_each), accepting an identifier from the outside, accepting a JsonQueryExpression...

We need to take a deeper look and open SelectExpression a bit so it can be properly constructed from the outside according to needs, rather than add a special constructor for each and every case. The problematic constructors are already marked as internal (though they're provider-facing!) so we can clean them up.

@roji
Copy link
Member Author

roji commented Jan 22, 2024

Mostly done in #32877. Some details remain to be seen, and things won't be truly final until SelectExpression becomes immutable and all logic is removed from it; but for now this is enough.

@roji roji closed this as completed Jan 22, 2024
@roji roji self-assigned this Jan 22, 2024
@roji roji modified the milestones: Backlog, 9.0.0 Jan 22, 2024
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 31, 2024
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1 Jan 31, 2024
@roji roji modified the milestones: 9.0.0-preview1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants