Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider writers need test packages on "Nuget.org" #3016

Closed
ErikEJ opened this issue Sep 4, 2015 · 15 comments
Closed

Provider writers need test packages on "Nuget.org" #3016

ErikEJ opened this issue Sep 4, 2015 · 15 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 4, 2015

it would be ideal/easier if the https://www.myget.org/gallery/aspnetbeta7take2/ (or future type feed) also included the EF test packages, pointing to betaX packages

@roji
Copy link
Member

roji commented Sep 4, 2015

+1, right now there is no EF test package which references beta7.

@rowanmiller
Copy link
Contributor

The purpose of https://www.myget.org/gallery/aspnetbeta7take2/ is to just include the packages that are going to be published to NuGet.org so that we can do final verification that there is nothing missing etc.

It sounds like we should consider just publishing the packages to NuGet.org though (probably as unlisted)

@divega
Copy link
Contributor

divega commented Sep 4, 2015

+1 I am starting to think that it would be ok to publish them to nuget.irg and maybe even listing them is OK.

@roji
Copy link
Member

roji commented Sep 4, 2015

That would definitely be easiest for me. Any reason not to list them? After all they're public-facing in the sense that they're provider-facing...

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Sep 4, 2015

+1 whether they are listed or not is not important, as long as they are available!

@ErikEJ ErikEJ changed the title Provider writers need test packages pointing to "Nuget.org" ready packages Provider writers need test packages on "Nuget.org" Sep 5, 2015
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Sep 5, 2015

Updated the title to reflect the desired goal

@roji
Copy link
Member

roji commented Sep 13, 2015

Additional request: if you guys could also release nugets of your unit test suites (EntityFramework.Core.Tests, EntityFramework.Relational.Tests), that would help us a lot. For example, both @ErikEJ and I duplicate MigrationSqlGeneratorTestBase.cs in our unit test suites because a nuget is missing.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Sep 13, 2015

@roji - now you are pushing it! 😈

@davidfowl
Copy link
Member

Same idea here aspnet/DependencyInjection#270

@roji
Copy link
Member

roji commented Sep 13, 2015

@ErikEJ that's how it works, you give pesky developers a little bit and they'll ask for a lot :)

@davidfowl yep. The EF7 team already publish a functional test suite, which is extremely useful when working on a database provider. But thers'a also an unpublished unit test suite.

@bricelam
Copy link
Contributor

@rowanmiller In terms of build and CI, everything looks good. Assigning to you to ensure they get published as part of the next release.

@bricelam bricelam assigned rowanmiller and unassigned bricelam Sep 15, 2015
@rowanmiller rowanmiller modified the milestones: 7.0.0-beta8, 7.0.0 Sep 17, 2015
@rowanmiller
Copy link
Contributor

@muratg can you add these packages to the list that gets published for Beta 8

  • EntityFramework.Core.FunctionalTests
  • EntityFramework.Relational.FunctionalTests
  • EntityFramework.Relational.Design.FunctionalTests

@muratg
Copy link

muratg commented Sep 17, 2015

It looks like these are new packages. I'll add these to the upload list.

@danroth27 FYI

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Oct 4, 2015

Those packages are now available in the beta8 myget feed, thanks for fixing this!

@ErikEJ ErikEJ closed this as completed Oct 4, 2015
@muratg
Copy link

muratg commented Oct 4, 2015

@ErikEJ NP, and they will be in nuget.org when we release beta 8 as well.

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers removed this from the 1.0.0-beta8 milestone Oct 15, 2022
@ajcvickers ajcvickers added this to the 1.0.0 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

8 participants