-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider writers need test packages on "Nuget.org" #3016
Comments
+1, right now there is no EF test package which references beta7. |
The purpose of https://www.myget.org/gallery/aspnetbeta7take2/ is to just include the packages that are going to be published to NuGet.org so that we can do final verification that there is nothing missing etc. It sounds like we should consider just publishing the packages to NuGet.org though (probably as unlisted) |
+1 I am starting to think that it would be ok to publish them to nuget.irg and maybe even listing them is OK. |
That would definitely be easiest for me. Any reason not to list them? After all they're public-facing in the sense that they're provider-facing... |
+1 whether they are listed or not is not important, as long as they are available! |
Updated the title to reflect the desired goal |
Additional request: if you guys could also release nugets of your unit test suites (EntityFramework.Core.Tests, EntityFramework.Relational.Tests), that would help us a lot. For example, both @ErikEJ and I duplicate MigrationSqlGeneratorTestBase.cs in our unit test suites because a nuget is missing. |
@roji - now you are pushing it! 😈 |
Same idea here aspnet/DependencyInjection#270 |
@ErikEJ that's how it works, you give pesky developers a little bit and they'll ask for a lot :) @davidfowl yep. The EF7 team already publish a functional test suite, which is extremely useful when working on a database provider. But thers'a also an unpublished unit test suite. |
@rowanmiller In terms of build and CI, everything looks good. Assigning to you to ensure they get published as part of the next release. |
@muratg can you add these packages to the list that gets published for Beta 8
|
It looks like these are new packages. I'll add these to the upload list. @danroth27 FYI |
Those packages are now available in the beta8 myget feed, thanks for fixing this! |
@ErikEJ NP, and they will be in nuget.org when we release beta 8 as well. |
it would be ideal/easier if the https://www.myget.org/gallery/aspnetbeta7take2/ (or future type feed) also included the EF test packages, pointing to betaX packages
The text was updated successfully, but these errors were encountered: