Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Strive for reusing common annotations and metadata APIs #2714

Closed
divega opened this issue Jul 24, 2015 · 3 comments
Closed

RevEng: Strive for reusing common annotations and metadata APIs #2714

divega opened this issue Jul 24, 2015 · 3 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Milestone

Comments

@divega
Copy link
Contributor

divega commented Jul 24, 2015

Our reverse engineering pipeline uses an IModel that is not bound to CLR types as a representation at various stages, including the model that is passed to the final code generation stage.

Note that IModels that are not bound to CLR types aren't full fidelity with all the capabilities of EF, e.g. per see #2140 it is not possible to represent unbound navigation properties. However, we should strive to reuse all the capabilities that are first class when we can, e.g. favor general purpose well-known annotations vs. reverse engineering-specific annotations for things like table names and column names, column types, and produce/consume the annotation through the strongly typed APIs we have created for that purpose, etc.

@rowanmiller
Copy link
Contributor

@lajones is this done now?

@lajones
Copy link
Contributor

lajones commented Sep 17, 2015

There's one more small place where I want to update the code.

@lajones
Copy link
Contributor

lajones commented Sep 21, 2015

This is now done with commit 057b8df.

@lajones lajones closed this as completed Sep 21, 2015
@lajones lajones modified the milestones: 7.0.0-beta8, 7.0.0 Sep 21, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta8, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Projects
None yet
Development

No branches or pull requests

4 participants