Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RelationalModelValidator validation for non-store-generated shared concurrency columns #21136

Closed
lajones opened this issue Jun 4, 2020 · 1 comment
Closed

Update RelationalModelValidator validation for non-store-generated shared concurrency columns #21136

lajones opened this issue Jun 4, 2020 · 1 comment
Labels
area-model-building closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-bug

Comments

@lajones
Copy link
Contributor

lajones commented Jun 4, 2020 •
edited
Loading

RelationalModelValidator.ValidateSharedColumnsCompatibility ensures (among other things) that EntityTypes are not missing a concurrency token property when properties share the same column. However the definition of "concurrency token property" only includes ones where it is also store-generated.

TableSharingConcurrencyTokenConvention was recently updated see (PR #21128 and associated issue #21041) to create such properties for all concurrency token properties, not just ones which are store-generated.

We should look into changing RelationalModelValidator in the same way.

Further technical details

EF Core version: 5.0.0-preview5
@lajones lajones self-assigned this Jun 4, 2020
This was referenced Jun 4, 2020
Closed
Merged
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jun 5, 2020
@ajcvickers ajcvickers assigned AndriySvyryd and unassigned lajones Jul 17, 2020
@AndriySvyryd
Copy link
Member

We only validate the store generated concurrency tokens because those are the ones that can change value when a table-sharing entity is updated without updating the other entities in the row.

@AndriySvyryd AndriySvyryd removed their assignment Jul 23, 2020
@AndriySvyryd AndriySvyryd added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Jul 23, 2020
@AndriySvyryd AndriySvyryd removed this from the 5.0.0 milestone Jul 23, 2020
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajcvickers @lajones @AndriySvyryd