Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate GroupBy followed by Distinct without aggregate operators #17761

Open
Tracked by #30173
smitpatel opened this issue Sep 10, 2019 · 1 comment
Open
Tracked by #30173

Translate GroupBy followed by Distinct without aggregate operators #17761

smitpatel opened this issue Sep 10, 2019 · 1 comment

Comments

@smitpatel
Copy link
Member

        [ConditionalTheory]
        [MemberData(nameof(IsAsyncData))]
        public virtual Task GroupBy_with_orderby_take_skip_distinct_followed_by_group_key_projection(bool isAsync)
        {
            return AssertQuery<Order>(
                isAsync,
                os => os.GroupBy(o => o.CustomerID).OrderBy(g => g.Key).Take(5).Skip(3).Distinct().Select(g => g.Key),
                assertOrder: true,
                elementAsserter: GroupingAsserter<string, Order>(o => o.OrderID),
                entryCount: 31);
        }
@smitpatel
Copy link
Member Author

On higher level, to translate correctly we also need to decide what exactly Distinct on IGroupings mean.

@divega divega added this to the Backlog milestone Sep 16, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@smitpatel smitpatel removed this from the 6.0.0 milestone Nov 6, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Nov 6, 2020
@roji roji changed the title GroupBy followed by distinct without aggregate operators generates invalid SQL Translate GroupBy followed by Distinct without aggregate operators Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants